Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: add telemetry for UDFs with RETURNS TABLE #100625

Merged
merged 1 commit into from
Apr 6, 2023
Merged

release-23.1: sql: add telemetry for UDFs with RETURNS TABLE #100625

merged 1 commit into from
Apr 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 4, 2023 •
edited by mgartner
Loading

Backport 1/1 commits from #100539 on behalf of @mgartner.

/cc @cockroachdb/release

Informs #100226

Release note: None

Release justification: Minor change to add telemetry for
unsupported UDF feature.

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100539 branch from 2674469 to 3d66add Compare April 4, 2023 18:55
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 4, 2023 18:55
@blathers-crl blathers-crl bot requested a review from rharding6373 April 4, 2023 18:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100539 branch from bdf68e6 to 8e6de00 Compare April 4, 2023 18:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 4, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 4, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested a review from rytaft April 5, 2023 14:14
rytaft
rytaft approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)

rharding6373
rharding6373 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit dfd25b1 into release-23.1 Apr 6, 2023
@mgartner mgartner deleted the blathers/backport-release-23.1-100539 branch April 6, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rharding6373 rharding6373 rharding6373 approved these changes

@rytaft rytaft rytaft approved these changes

Assignees

@mgartner mgartner

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @rytaft @rharding6373 @mgartner