Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add telemetry for UDFs with RETURNS TABLE #100539

Merged
merged 1 commit into from
Apr 4, 2023
Merged

sql: add telemetry for UDFs with RETURNS TABLE #100539

merged 1 commit into from
Apr 4, 2023

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Apr 3, 2023

Informs #100226

Release note: None

@mgartner mgartner requested review from rharding6373 and a team April 3, 2023 23:20
@mgartner mgartner requested a review from a team as a code owner April 3, 2023 23:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

rharding6373
rharding6373 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@mgartner mgartner added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 4, 2023
@mgartner
Copy link
Collaborator Author

mgartner commented Apr 4, 2023

TFYR

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 4, 2023

Build succeeded:

@craig craig bot merged commit ef357d1 into cockroachdb:master Apr 4, 2023
@blathers-crl blathers-crl bot mentioned this pull request Apr 4, 2023
Merged
@mgartner mgartner deleted the 100226-telemetry-for-return-table branch April 4, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rharding6373 rharding6373 rharding6373 approved these changes

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgartner @cockroach-teamcity @rharding6373