Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: fix read-only SSL var #100506

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 3, 2023

Backport 1/1 commits from #100355 on behalf of @rafiss.

/cc @cockroachdb/release


The variable will now look at the connection state to determine if SSL/TLS is being used, rather than relying on server configuration params, which aren't sufficient to be able to determine the type of connection.

fixes #99606
Release note: None


Release justification: correctness fix

The variable will now look at the connection state to determine if
SSL/TLS is being used, rather than relying on server configuration
params, which aren't sufficient to be able to determine the type of
connection.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 3, 2023 19:29
@blathers-crl blathers-crl bot requested review from a team as code owners April 3, 2023 19:29
@blathers-crl blathers-crl bot requested a review from cucaroach April 3, 2023 19:29
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100355 branch from 671f0c2 to 4a8182a Compare April 3, 2023 19:29
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100355 branch from 3dfe59a to 84e710d Compare April 3, 2023 19:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from knz April 3, 2023 19:31
@rafiss rafiss self-assigned this Apr 3, 2023
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@rafiss rafiss merged commit 35b7249 into release-23.1 Apr 4, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1-100355 branch April 4, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants