Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: the ssl session var is incorrectly defined #99606

Closed
knz opened this issue Mar 26, 2023 · 0 comments · Fixed by #100355
Closed

sql: the ssl session var is incorrectly defined #99606

knz opened this issue Mar 26, 2023 · 0 comments · Fixed by #100355
Assignees
@rafiss
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@knz
Copy link
Contributor

knz commented Mar 26, 2023 •
edited by cockroach-jira-scripts
Loading

Describe the problem

The pg-compatible ssl session var is currently defined based on some server parameters, and is shared across all sessions on that server.

In particular, it is always set to false if the server accepts non-TLS connections, even on those connections where TLS is enabled.

Expected behavior

The value should be set per client connection depending on the connection type, like in PostgreSQL.

The proper location to set it would be in sql/pgwire, after the connection type is known.

cc @rafiss for triage

Jira issue: CRDB-25974
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL labels Mar 26, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 26, 2023
@rafiss rafiss self-assigned this Mar 31, 2023
@rafiss rafiss mentioned this issue Mar 31, 2023
Merged
@craig craig bot closed this as completed in 6cd1f1b Apr 3, 2023
@blathers-crl blathers-crl bot mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix read-only SSL var rafiss/cockroach
2 participants
@knz @rafiss