Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: kvserver: add leases.requests.latency metric #100474

Merged
merged 1 commit into from
Apr 30, 2023
Merged

release-22.2: kvserver: add leases.requests.latency metric #100474

merged 1 commit into from
Apr 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 3, 2023

Backport 1/1 commits from #100287 on behalf of @erikgrinaker.

/cc @cockroachdb/release

This patch adds a histogram of lease request latencies. It includes all request types (acquisitions, transfers, and extensions) and all outcomes (successes and errors), but only considers the coalesced lease requests regardless of the number of waiters and how long they have been waiting for.

Epic: none
Release note (ops change): Added a metric leases.requests.latency recording a histogram of lease request latencies.

Release justification:

@blathers-crl blathers-crl bot requested a review from a team April 3, 2023 14:14
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 3, 2023 14:14
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-100287 branch from 360d268 to af0d1d4 Compare April 3, 2023 14:15
@blathers-crl blathers-crl bot requested a review from andrewbaptist April 3, 2023 14:15
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-100287 branch from 00cbddd to 7bdc0bc Compare April 3, 2023 14:15
@blathers-crl blathers-crl bot requested review from nvanbenschoten and a team April 3, 2023 14:15
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 3, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 3, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 3, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@abarganier abarganier removed the request for review from a team April 4, 2023 14:36
andrewbaptist
andrewbaptist approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@erikgrinaker
kvserver: add leases.requests.latency metric
8e7edf0 
This patch adds a histogram of lease request latencies. It includes all
request types (acquisitions, transfers, and extensions) and all
outcomes (successes and errors), but only considers the coalesced lease
requests regardless of the number of waiters and how long they have been
waiting for.

Epic: none
Release note (ops change): Added a metric `leases.requests.latency`
recording a histogram of lease request latencies.
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-100287 branch from 7bdc0bc to 8e7edf0 Compare April 26, 2023 21:11
@erikgrinaker erikgrinaker merged commit bb0e721 into release-22.2 Apr 30, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-22.2-100287 branch April 30, 2023 22:20
@cockroach-teamcity cockroach-teamcity mentioned this pull request May 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbaptist andrewbaptist andrewbaptist approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees

@erikgrinaker erikgrinaker

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @andrewbaptist @erikgrinaker