Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: add leases.requests.latency metric #100287

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

erikgrinaker
Copy link
Contributor

This patch adds a histogram of lease request latencies. It includes all request types (acquisitions, transfers, and extensions) and all outcomes (successes and errors), but only considers the coalesced lease requests regardless of the number of waiters and how long they have been waiting for.

Epic: none
Release note (ops change): Added a metric leases.requests.latency recording a histogram of lease request latencies.

@erikgrinaker erikgrinaker self-assigned this Mar 31, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner March 31, 2023 11:44
@blathers-crl
Copy link

blathers-crl bot commented Mar 31, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the lease-request-latency branch from 0bfc73f to d72b473 Compare March 31, 2023 11:45
@erikgrinaker erikgrinaker added backport-22.1.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Mar 31, 2023
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Note that you need to update the chart_catalog also to get this to be mergeable (or wait for Tobi to delete it).

@erikgrinaker erikgrinaker force-pushed the lease-request-latency branch from d72b473 to 4b46718 Compare April 2, 2023 17:45
@erikgrinaker erikgrinaker requested a review from a team April 2, 2023 17:45
@erikgrinaker erikgrinaker force-pushed the lease-request-latency branch from 4b46718 to 11b014a Compare April 2, 2023 18:40
This patch adds a histogram of lease request latencies. It includes all
request types (acquisitions, transfers, and extensions) and all
outcomes (successes and errors), but only considers the coalesced lease
requests regardless of the number of waiters and how long they have been
waiting for.

Epic: none
Release note (ops change): Added a metric `leases.requests.latency`
recording a histogram of lease request latencies.
@erikgrinaker erikgrinaker force-pushed the lease-request-latency branch from 11b014a to 0c41a7e Compare April 2, 2023 20:29
@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 2, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Apr 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 0c41a7e to blathers/backport-release-22.1-100287: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants