Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: add a regression test for virtual table generation hang #100258

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 31, 2023

Backport 1/1 commits from #100003 on behalf of @yuzefovich.

/cc @cockroachdb/release


This commit adds a regression test for #99753 that verifies that virtual table generation doesn't hang when the worker goroutine returns the query canceled error.

Informs #99753

Release note: None


Release justification: test-only change.

@blathers-crl blathers-crl bot requested a review from a team March 31, 2023 05:12
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100003 branch 2 times, most recently from 6710bad to aa6af1e Compare March 31, 2023 05:12
@blathers-crl blathers-crl bot requested review from cucaroach and rafiss March 31, 2023 05:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 31, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 31, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich added the do-not-merge bors won't merge a PR with this label. label Mar 31, 2023
@yuzefovich
Copy link
Member

This can wait for 23.1.1.

@yuzefovich yuzefovich removed the do-not-merge bors won't merge a PR with this label. label Apr 12, 2023
This commit adds a regression test for #99753 that verifies that virtual
table generation doesn't hang when the worker goroutine returns the
query canceled error.

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-23.1-100003 branch from aa6af1e to 1c21f22 Compare April 12, 2023 03:52
@yuzefovich yuzefovich merged commit c8a4703 into release-23.1 Apr 12, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-100003 branch April 12, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants