sql: add a regression test for virtual table generation hang #100003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit adds a regression test for cockroachdb#99753 that verifies that virtual table generation doesn't hang when the worker goroutine returns the query canceled error. Release note: None
yuzefovich
force-pushed
the
vt-regression
branch
from
e5c7c32 to
e0f0f6c
Compare
rafiss
approved these changes
Mar 30, 2023
yuzefovich
added
the
backport-23.1.x
|
TFTR! bors r+ |
|
Timed out. |
|
Seems like a flake. bors r+ |
|
Build succeeded: |
|
blathers backport 23.1.0 |
|
Ignore the backport to 23.1.0 - didn't realize we were waiting for 23.1.1 for backporting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a regression test for #99753 that verifies that virtual table generation doesn't hang when the worker goroutine returns the query canceled error.
Informs #99753
Release note: None