grpcutil: consider WaitingForInitError as unambiguous
#100213
Conversation
Epic: none Release note: None
Previously, `WaitingForInitError` could be considered ambiguous to a 1PC write in DistSender. This could cause synchronous writes during node startup to fatally error out if they encountered such a node. This may have become a more common failure mode in roachtests following a788bfb, which introduced such a write early during node startup. This patch marks such errors as unambiguous, allowing the DistSender to retry them. Epic: none Release note: None
erikgrinaker
added
the
backport-23.1.x
|
This change is |
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 45a46ee to blathers/backport-release-22.1-100213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from 45a46ee to blathers/backport-release-22.2-100213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-100213 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100277/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
99304: backupccl: add test with randomized completed spans to TestRestoreEntryCover r=rhu713 a=rhu713 Add some testing with randomized completed spans to TestRestoreEntryCover. This testing should demonstrate the correctness of generateAndSendImportSpans in the presence of completed spans. Informs: #98779 Release note: None 100287: kvserver: add `leases.requests.latency` metric r=erikgrinaker a=erikgrinaker This patch adds a histogram of lease request latencies. It includes all request types (acquisitions, transfers, and extensions) and all outcomes (successes and errors), but only considers the coalesced lease requests regardless of the number of waiters and how long they have been waiting for. Epic: none Release note (ops change): Added a metric `leases.requests.latency` recording a histogram of lease request latencies. 100450: roachtest: unskip `acceptance/gossip/peerings` r=erikgrinaker a=erikgrinaker Addressed by bfed880. Resolves #96091. Touches #100213. Epic: none Release note: None Co-authored-by: Rui Hu <[email protected]> Co-authored-by: Erik Grinaker <[email protected]>
Previously,
WaitingForInitErrorcould be considered ambiguous to a 1PC write in DistSender. This could cause synchronous writes during node startup to fatally error out if they encountered such a node. This may have become a more common failure mode in roachtests following a788bfb, which introduced such a write early during node startup.This patch marks such errors as unambiguous, allowing the DistSender to retry them.
Resolves #99523.
Resolves #99568.
Epic: none
Release note: None