Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: deflake TestRejectedLeaseDoesntDictateClosedTimestamp #100155

Merged
merged 1 commit into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/kv/kvserver/client_raft_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2093,10 +2093,10 @@ func runReplicateRestartAfterTruncation(t *testing.T, removeBeforeTruncateAndReA
},
},
RaftConfig: base.RaftConfig{
// Don't timeout raft leaders or range leases (see the relation between
// RaftElectionTimeoutTicks and RangeLeaseActiveDuration). This test expects
// Don't timeout raft leaders or range leases. This test expects
// tc.Servers[0] to hold the range lease for the range under test.
RaftElectionTimeoutTicks: 1000000,
RangeLeaseDuration: time.Minute,
},
}
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/kv/kvserver/closed_timestamp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -680,12 +680,12 @@ func TestClosedTimestampFrozenAfterSubsumption(t *testing.T) {
ServerArgs: base.TestServerArgs{
Settings: cs,
RaftConfig: base.RaftConfig{
// We set the raft election timeout to a small duration. This should
// result in the node liveness duration being ~3.6 seconds. Note that
// We set the raft election timeout to a small duration. Note that
// if we set this too low, the test may flake due to the test
// cluster's nodes frequently missing their liveness heartbeats.
RaftHeartbeatIntervalTicks: 5,
RaftElectionTimeoutTicks: 6,
RangeLeaseDuration: 3 * time.Second,
},
Knobs: base.TestingKnobs{
Server: &server.TestingKnobs{
Expand Down
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/replica_closedts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ func TestRejectedLeaseDoesntDictateClosedTimestamp(t *testing.T) {
RangeLeaseRenewalFraction: -1,
// Also make expiration-based leases last for a long time, as the test
// wants a valid lease after cluster start.
RaftElectionTimeoutTicks: 1000,
RangeLeaseDuration: time.Minute,
},
Knobs: base.TestingKnobs{
Server: &server.TestingKnobs{
Expand Down