Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: deflake TestRejectedLeaseDoesntDictateClosedTimestamp #100155

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023

Backport 1/1 commits from #100111 on behalf of @erikgrinaker.

/cc @cockroachdb/release


And friends.

In 40cb075 we decoupled the lease duration from the Raft election timeout. Some tests still relied on the election timeout to control lease durations.

Resolves #98938.
Resolves #99639.

Epic: none
Release note: None


Release justification: deflakes tests.

And friends.

In `40cb0758` we decoupled the lease duration from the Raft election
timeout. Some tests still relied on the election timeout to control
lease durations.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team March 30, 2023 16:13
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100111 branch from 9d70e72 to 6639aa5 Compare March 30, 2023 16:13
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from pav-kv March 30, 2023 16:13
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100111 branch from fe18c93 to a554fe1 Compare March 30, 2023 16:13
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker requested a review from nicktrav March 30, 2023 16:14
@erikgrinaker erikgrinaker merged commit 1d52bf4 into release-23.1 Mar 30, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-23.1-100111 branch March 30, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants