-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/streamingccl/streamingest: TestRandomClientGeneration failed #99343
Comments
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ f351747ed97862fc037717cadec23f18073fb6be:
Parameters: |
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ b995ddff53ee95a30537a366c6cd8e0e13fcee79:
Parameters: |
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 186218edb86b5974501b2976cfd0704d4d6d1beb:
Parameters: |
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 3551dc089ac3efcb3772df2109164dcb01e79d8f:
Parameters: Same failure on other branches
|
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ a34af06d8e7230e4052db80d55da21a06013f81b:
Parameters: Same failure on other branches
|
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 7e72aae900c3ff4b44f1643c2d7ba55fbb2cbe23:
Parameters: Same failure on other branches
|
@stevendanna I think #97845 is responsible for this failure.
|
oh fun, it has something to do with the locking implementation I recommended 67ba17f . The test only fails when this commit is included.... |
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 63b683eab3e0ebfff812bb54fdac936c101d9383:
Parameters: Same failure on other branches
|
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 63b683eab3e0ebfff812bb54fdac936c101d9383:
Parameters: Same failure on other branches
|
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ b432e8c20339de5cfa7c811a9ee6f5dc98d15a1e:
Parameters: Same failure on other branches
|
This patch fixes 4 bugs in TestRandomClientGeneration that were responsible for the persistent flakiness and lack of coverage in this test: - the randomeStreamClient no longer instantiates keys with a table prefix that collides with the job info table prefix. This collision was the original cause of the flakes reported in cockroachdb#99343. - getPartitionSpanToTableId() now generates a correct map from source partition key space to table Id. Previously, the key spans in the map didn't contain keys that mapped to anything logical in the cockroach key space. - assertKVs() now checks for keys in the destination tenant keyspace. - assertKVs() now actually asserts that kvs were found. Before, the assertion could pass if no keys were actually checked, which has been happening for months and allowed the bugs above to infest this test. Fixes cockroachdb#99343 Release note: None
100813: streamingccl: deflake TestRandomClientGeneration r=adityamaru a=msbutler This patch fixes 4 bugs in TestRandomClientGeneration that were responsible for the persistent flakiness and lack of coverage in this test: - the randomeStreamClient no longer instantiates keys with a table prefix that collides with the job info table prefix. This collision was the original cause of the flakes reported in #99343. - getPartitionSpanToTableId() now generates a correct map from source partition key space to table Id. Previously, the key spans in the map didn't contain keys that mapped to anything logical in the cockroach key space. - assertKVs() now checks for keys in the destination tenant keyspace. - assertKVs() now actually asserts that kvs were found. Before, the assertion could pass if no keys were actually checked, which has been happening for months and allowed the bugs above to infest this test. Fixes #99343 Release note: None 100952: cli: trash `TestNoLinkForbidden` r=rail a=rickystewart This test does not work: 1. The test [has been broken](#74119) for years. 2. The test is not sensible in the Bazel world anyway, and under remote execution the test fails with an error like the following: ``` build.go:59: go/build: go list github.com/cockroachdb/cockroach/pkg/cmd/cockroach: fork/exec GOROOT/bin/go: no such file or directory ``` The bug to replace this test with working functionality based on Bazel is #81526. Epic: CRDB-17165 Release note: None Closes #74119. 100965: sql: link issue to unimplemented mutations in udfs r=mgartner,rytaft a=rharding6373 Links an issue to the unimplemented errors for mutations in UDFs. Epic: None Informs: #87289 Fixes: #99715 Release note: None Co-authored-by: Michael Butler <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: rharding6373 <[email protected]>
This patch fixes 4 bugs in TestRandomClientGeneration that were responsible for the persistent flakiness and lack of coverage in this test: - the randomeStreamClient no longer instantiates keys with a table prefix that collides with the job info table prefix. This collision was the original cause of the flakes reported in cockroachdb#99343. - getPartitionSpanToTableId() now generates a correct map from source partition key space to table Id. Previously, the key spans in the map didn't contain keys that mapped to anything logical in the cockroach key space. - assertKVs() now checks for keys in the destination tenant keyspace. - assertKVs() now actually asserts that kvs were found. Before, the assertion could pass if no keys were actually checked, which has been happening for months and allowed the bugs above to infest this test. Fixes cockroachdb#99343 Release note: None
This patch fixes 4 bugs in TestRandomClientGeneration that were responsible for the persistent flakiness and lack of coverage in this test: - the randomeStreamClient no longer instantiates keys with a table prefix that collides with the job info table prefix. This collision was the original cause of the flakes reported in #99343. - getPartitionSpanToTableId() now generates a correct map from source partition key space to table Id. Previously, the key spans in the map didn't contain keys that mapped to anything logical in the cockroach key space. - assertKVs() now checks for keys in the destination tenant keyspace. - assertKVs() now actually asserts that kvs were found. Before, the assertion could pass if no keys were actually checked, which has been happening for months and allowed the bugs above to infest this test. Fixes #99343 Release note: None
ccl/streamingccl/streamingest.TestRandomClientGeneration failed with artifacts on release-23.1 @ 751b17200b6026b73351c57cab734415d2c4b02a:
Parameters:
TAGS=bazel,gss,race
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-25832
The text was updated successfully, but these errors were encountered: