cli: trash TestNoLinkForbidden
#100952
Merged
cli: trash TestNoLinkForbidden
#100952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
nolinkforbidden
branch
from
64cceec to
79639d2
Compare
This test does not work: 1. The test [has been broken](cockroachdb#74119) for years. 2. The test is not sensible in the Bazel world anyway, and under remote execution the test fails with an error like the following: ``` build.go:59: go/build: go list github.com/cockroachdb/cockroach/pkg/cmd/cockroach: fork/exec GOROOT/bin/go: no such file or directory ``` The bug to replace this test with working functionality based on Bazel is cockroachdb#81526. Epic: CRDB-17165 Release note: None Closes cockroachdb#74119.
rickystewart
force-pushed
the
nolinkforbidden
branch
from
79639d2 to
3522c98
Compare
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test does not work:
The bug to replace this test with working functionality based on Bazel is #81526.
Epic: CRDB-17165
Release note: None
Closes #74119.