Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestReplicateQueueDecommissioningNonVoters failed #99207

Closed
cockroach-teamcity opened this issue Mar 22, 2023 · 0 comments · Fixed by #100785
Closed

kv/kvserver: TestReplicateQueueDecommissioningNonVoters failed #99207

cockroach-teamcity opened this issue Mar 22, 2023 · 0 comments · Fixed by #100785
Assignees
@AlexTalks
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 22, 2023 •
edited by cockroach-jira-scripts
Loading

kv/kvserver.TestReplicateQueueDecommissioningNonVoters failed with artifacts on release-23.1 @ 80c4895c566a7eaa6f16c4098980509dd3795ad7:

=== RUN   TestReplicateQueueDecommissioningNonVoters
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/33e1d369c27b9c01b2b6009c561815a3/logTestReplicateQueueDecommissioningNonVoters2486490881
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestReplicateQueueDecommissioningNonVoters
    replicate_queue_test.go:819: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/33e1d369c27b9c01b2b6009c561815a3/logTestReplicateQueueDecommissioningNonVoters2486490881
--- FAIL: TestReplicateQueueDecommissioningNonVoters (109.23s)
=== RUN   TestReplicateQueueDecommissioningNonVoters/remove
    replicate_queue_test.go:793: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/kv/kvserver_test/pkg/kv/kvserver/replicate_queue_test.go:793
        	Error:      	Condition never satisfied
        	Test:       	TestReplicateQueueDecommissioningNonVoters/remove
    --- FAIL: TestReplicateQueueDecommissioningNonVoters/remove (68.62s)

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-25756
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 22, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 22, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Mar 22, 2023
@AlexTalks AlexTalks self-assigned this Mar 29, 2023
This was referenced Apr 6, 2023
Closed
Merged
craig bot pushed a commit that referenced this issue Apr 14, 2023
@AlexTalks
Merge #100785
d50149d 
100785: kvserver: skip replicate queue tests under metamorphic builds r=AlexTalks a=AlexTalks

This modifies `TestReplicateQueueDecommissioningNonVoters` to be skipped specifically under metamorphic builds because this may enable mux range feeds, which are not currently working in these test builds (#100783). Once this issue is resolved and the test can work successfully with mux range feeds, this check should be removed.

Fixes: #99207

Release note: None

Co-authored-by: Alex Sarkesian <[email protected]>
@craig craig bot closed this as completed in 8481c26 Apr 14, 2023
@blathers-crl blathers-crl bot mentioned this issue Apr 14, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Apr 14, 2023
@AlexTalks
kvserver: skip replicate queue tests under metamorphic builds
debcd7c 
This modifies `TestReplicateQueueDecommissioningNonVoters` to be skipped
specifically under metamorphic builds because this may enable mux range
feeds, which are not currently working in these test builds (#100783).
Once this issue is resolved and the test can work successfully with mux
range feeds, this check should be removed.

Fixes: #99207

Release note: None
@AlexTalks AlexTalks mentioned this issue Apr 19, 2023
Closed
AlexTalks added a commit to AlexTalks/cockroach that referenced this issue Apr 19, 2023
@AlexTalks
kvserver: skip decommissioning test under metamorphic builds
9140b34 
Similar to the issue found in cockroachdb#99207, it was discovered that
`TestDecommission` is also failing due to cockroachdb#100783 - under metamorphic
builds, mux range feeds (among other settings) are enabled, which cause
span config updates (which depend on range feeds) to fail. As can be
seen in the test, this causes expectations on things such as the
replication factor applied to a range to fail due to being out-of-date.
Until cockroachdb#100783 is fixed, this changes `TestDecommission` to be skipped
under metamorphic builds; stressing this test has shown that it succeeds
repeatedly when in a non-metamorphic build.

Fixes: cockroachdb#96630

Release note: None
This was referenced May 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexTalks AlexTalks

Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

kvserver: skip replicate queue tests under metamorphic builds AlexTalks/cockroach
3 participants
@AlexTalks @nvanbenschoten @cockroach-teamcity