Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazci: panic when nogo finds an error #98861

Closed
renatolabs opened this issue Mar 17, 2023 · 0 comments · Fixed by #99509
Closed

bazci: panic when nogo finds an error #98861

renatolabs opened this issue Mar 17, 2023 · 0 comments · Fixed by #99509
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@renatolabs
Copy link
Contributor

renatolabs commented Mar 17, 2023 •
edited by exalate-issue-sync bot
Loading

bazci panicked after nogo found a problem during build:

[Run Bazel build] panic: runtime error: invalid memory address or nil pointer dereference
[Run Bazel build] [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xbc36f3]
[Run Bazel build] 
[Run Bazel build] goroutine 58 [running]:
[Run Bazel build] main.(*monitorBuildServer).Finalize(0xc000038de0)
[Run Bazel build] 	main/pkg/cmd/bazci/bazci.go:249 +0xd3
[Run Bazel build] main.(*monitorBuildServer).PublishBuildToolEventStream(0xc000120b10?, {0xf4aff0, 0xc000128240})
[Run Bazel build] 	main/pkg/cmd/bazci/bazci.go:162 +0xff
[Run Bazel build] google.golang.org/genproto/googleapis/devtools/build/v1._PublishBuildEvent_PublishBuildToolEventStream_Handler({0xce2d60?, 0xc000038de0}, {0xf494c8?, 0xc0005b8000})
[Run Bazel build] 	google.golang.org/genproto/googleapis/devtools/build/v1/bazel-out/k8-fastbuild/bin/external/go_googleapis/google/devtools/build/v1/build_go_proto_/google.golang.org/genproto/googleapis/devtools/build/v1/publish_build_event.pb.go:816 +0x9f
[Run Bazel build] google.golang.org/grpc.(*Server).processStreamingRPC(0xc0003b6b40, {0xf4b498, 0xc00045c820}, 0xc0003e0360, 0xc0004366f0, 0x14a07a0, 0x0)
[Run Bazel build] 	google.golang.org/grpc/external/org_golang_google_grpc/server.go:1629 +0x11e7
[Run Bazel build] google.golang.org/grpc.(*Server).handleStream(0xc0003b6b40, {0xf4b498, 0xc00045c820}, 0xc0003e0360, 0x0)
[Run Bazel build] 	google.golang.org/grpc/external/org_golang_google_grpc/server.go:1717 +0x9ea
[Run Bazel build] google.golang.org/grpc.(*Server).serveStreams.func1.2()
[Run Bazel build] 	google.golang.org/grpc/external/org_golang_google_grpc/server.go:965 +0x98
[Run Bazel build] created by google.golang.org/grpc.(*Server).serveStreams.func1
[Run Bazel build] 	google.golang.org/grpc/external/org_golang_google_grpc/server.go:963 +0x28a

Example: https://teamcity.cockroachdb.com/viewLog.html?buildId=9114428&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_BazelBuildMacOSCross.

Same happened in various other builds when trying to merge #98608 (see parent build).

@cockroachdb/dev-inf

Jira issue: CRDB-25552

Epic CRDB-15060
@renatolabs renatolabs added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf labels Mar 17, 2023
@rickystewart rickystewart mentioned this issue Mar 24, 2023
Merged
craig bot pushed a commit that referenced this issue Mar 27, 2023
@rickystewart @ericharmeling
@knz @nvanbenschoten
Merge #99509 #99532 #99642 #99660
b1a20ba 
99509: bazci: protect against `nil` target r=healthy-pod a=rickystewart

Closes #98861.

Epic: none

Release note: None

99532: sql: inject stats into TestExecBuild_sql_statistics_persisted testdata r=ericharmeling a=ericharmeling

Background thread: #99240 (comment)

Part of #99399.

This commit replaces the `CREATE STATISTICS` statements in the `TestExecBuild_sql_statistics_persisted` testdata with `ALTER TABLE ... INJECT STATISTICS` and removes the retry directives added to deflake the test in #99447.

Epic: none

Release note: None

99642: serverccl: skip TestServerControllerHTTP under deadlock r=dhartunian a=knz

Fixes #98046.
Release note: None

99660: workload/tpcc: disable check 3.3.2.11 after workload r=renatolabs a=nvanbenschoten

Fixes #99619.
Fixes #99594.
Fixes #99603.
Fixes #99604.
Fixes #99617.
Fixes #99616.
Fixes #99613.
Fixes #99611.
Fixes #99604.
Fixes #99603.
Fixes #99600.
Fixes #99599.
Fixes #99598.
Fixes #99596.
Fixes #99595.
Fixes #99594.

This commit disables TPC-C's consistency check 3.3.2.11 (added in #99542) after the workload has run. The check asserts a relationship between the number of rows in the "order" table and rows in the "new_order" table. Rows are inserted into these tables transactional by the NewOrder transaction. However, only rows in the "new_order" table are deleted by the Delivery transaction. Consequently, the consistency condition will fail after the first Delivery transaction is run by the workload.

See #99542 (comment) for more details.

Release note: None

Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: Eric Harmeling <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 92efe7d Mar 27, 2023
aadityasondhi pushed a commit to aadityasondhi/cockroach that referenced this issue Mar 28, 2023
@rickystewart @aadityasondhi
bazci: protect against nil target
6fa45c1 
Closes cockroachdb#98861.

Epic: none

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazci: protect against nil target rickystewart/cockroach
1 participant
@renatolabs