Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serverccl: skip TestServerControllerHTTP under deadlock #99642

Merged
merged 1 commit into from
Mar 27, 2023
Merged

serverccl: skip TestServerControllerHTTP under deadlock #99642

merged 1 commit into from
Mar 27, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Mar 27, 2023

Fixes #98046.
Release note: None

@knz knz requested a review from stevendanna March 27, 2023 12:07
@knz knz requested a review from a team as a code owner March 27, 2023 12:07
@knz knz requested a review from dhartunian March 27, 2023 12:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Mar 27, 2023
@knz knz mentioned this pull request Mar 27, 2023
Closed
@knz knz force-pushed the 20230327-test-deadlock branch from 958388e to 2133e67 Compare March 27, 2023 13:20
dhartunian
dhartunian approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)

@knz
Copy link
Contributor Author

knz commented Mar 27, 2023

TFYR

bors r=dhartunian

@craig
Copy link
Contributor

craig bot commented Mar 27, 2023

Build succeeded:

@craig craig bot merged commit b1a20ba into cockroachdb:master Mar 27, 2023
@blathers-crl blathers-crl bot mentioned this pull request Mar 27, 2023
Merged
@blathers-crl
Copy link

blathers-crl bot commented Mar 27, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian dhartunian approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ccl/serverccl: TestServerControllerHTTP failed
3 participants
@knz @cockroach-teamcity @dhartunian