-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/multiregionccl: TestMultiRegionDatabaseStats failed #96163
Comments
Adding to @cockroachdb/sql-observability since that team wrote this test. |
Update: I'm unable to reproduce this test failure ATM. Just ran |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ 286b3e235171a39b8f9910555affcc7ce310741a:
Parameters: |
Can we modify the test to maybe log the entire crdb_internal.ranges table if it fails to see what the ranges are to help isolate the issue? |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ fcea283ebca17a6d923c5d4b0401697438b77dbd:
Parameters: |
I'm having trouble reproducing this error. 0 failures after 15000+ runs. |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ 85e41ca8d3d9edacf5ee3061a2591b159b9b0502:
Parameters: |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ 8124bff03d073f35f4d2b6a2048c7f4417d757d9:
Parameters: |
Closing as duplicate of: #102761 |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ f295bd861a3a427652b19c2254d2401ebb4a3c8e:
Parameters: |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ fcfa15d9694c0b840ac0c5c1b1489fa90a62efd8:
Parameters: |
Resolves: cockroachdb#96163 This change makes the admin API endpoint getting database statistics scan KV for span statistics instead of using the range descriptor cache. This provides authoritative output, helping deflake `TestMultiRegionDatabaseStats`. Release note (sql change): admin API database details endpoint now returns authoritative range statistics.
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ 1382b26a97bf6f70a07d363dc319283c173359eb:
Parameters: |
Flaked again here. |
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ a598a75435f6426236dde569191fbd95871f24ae:
Parameters: |
Resolves: cockroachdb#96163 This change makes the admin API endpoint getting database statistics scan KV for span statistics instead of using the range descriptor cache. This provides authoritative output, helping deflake `TestMultiRegionDatabaseStats`. Release note (sql change): admin API database details endpoint now returns authoritative range statistics.
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ c13bf7633cbb416d9e43f8c57b1e309fab1110ce:
Parameters: |
107965: roachtest: roachprod: add test name and run id vm labels for metrics r=herkolategan a=smg260 These 2 commits add labels to clusters running roachtests, so that metrics can be better filtered in various dashboards. 1. Adds `test_name` label to each cluster, and removes the label at the end of the test. Thus, each cluster would have this label updated for each test that it runs during a particular roachtest invocation. The test name will be simplified to conform to cloud labelling rules `[a-zA-Z-]` 2. Adds `test_run_id` label to each VM, *once*, for the duration of the run. Thus, each cluster would have this label added once at the beginning of a roachtest run (which would include multiple tests), and removed only after deregistration at the end. \ In TeamCity this would take the form `<TC_USER>-<TC_BUILD_ID>`, and run locally `<USER>-<UNIX_TS>` These 2 labels combined will allow it easy for a user to find metrics for a particular run of roachtest. (e.g. a specific GCE nightly) Here is a [copy of an existing dashboard](https://grafana.testeng.crdb.io/d/qdkBruq4k/crdb-console-runtime-by-test?orgId=1&from=now-3h&to=now), modified to utilise the new labels. Epic: None Fixes: #98658 Release note: None 108037: server: return authoritative span statistics for db details endpoint r=THardy98 a=THardy98 Resolves: #96163 This change makes the admin API endpoint getting database statistics scan KV for span statistics instead of using the range descriptor cache. This provides authoritative output, helping deflake `TestMultiRegionDatabaseStats`. Release note (sql change): admin API database details endpoint now returns authoritative range statistics. 108711: upgrades: deflake TestRoleMembersIDMigration1500Users r=rafiss a=rafiss TeamCity has a new machine type where this test has started to time out more, so this change will make it take less time. fixes #108539 Release note: None Co-authored-by: Miral Gadani <[email protected]> Co-authored-by: Thomas Hardy <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
Resolves: cockroachdb#96163 This change makes the admin API endpoint getting database statistics scan KV for span statistics instead of using the range descriptor cache. This provides authoritative output, helping deflake `TestMultiRegionDatabaseStats`. Release note (sql change): admin API database details endpoint now returns authoritative range statistics.
ccl/multiregionccl.TestMultiRegionDatabaseStats failed with artifacts on master @ 69dd453d0e61e258f402c5751de310405743cd18:
Parameters:
TAGS=bazel,gss,deadlock
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-23975
The text was updated successfully, but these errors were encountered: