Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades: deflake TestRoleMembersIDMigration1500Users #108711

Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 14, 2023

TeamCity has a new machine type where this test has started to time out more, so this change will make it take less time.

fixes #108539
Release note: None

@rafiss rafiss requested review from andyyang890 and a team August 14, 2023 14:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

TeamCity has a new machine type where this test has started to time out
more, so this change will make it take less time.

Release note: None
@rafiss rafiss force-pushed the deflake-TestRoleMembersIDMigration1500Users branch from 56b2c59 to 08b2eb7 Compare August 14, 2023 15:17
@rafiss rafiss requested a review from andyyang890 August 14, 2023 15:17
Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 14, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 14, 2023

Build succeeded:

@craig craig bot merged commit dc2c52d into cockroachdb:master Aug 14, 2023
@rafiss rafiss deleted the deflake-TestRoleMembersIDMigration1500Users branch August 18, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade/upgrades: TestRoleMembersIDMigration1500Users is flaky
3 participants