Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/streamingccl/streamingest: TestTenantStreamingCutoverOnSourceFailure failed #94034

Closed
cockroach-teamcity opened this issue Dec 21, 2022 · 1 comment · Fixed by #94180
Closed

ccl/streamingccl/streamingest: TestTenantStreamingCutoverOnSourceFailure failed #94034

cockroach-teamcity opened this issue Dec 21, 2022 · 1 comment · Fixed by #94180
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 21, 2022 •
edited by cockroach-jira-scripts
Loading

ccl/streamingccl/streamingest.TestTenantStreamingCutoverOnSourceFailure failed with artifacts on master @ 10266a323f94c3cf397d5de590e512d987e63e22:

=== RUN   TestTenantStreamingCutoverOnSourceFailure
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/90c1b75d835f45b8488807abb5b1092d/logTestTenantStreamingCutoverOnSourceFailure647287828
    test_log_scope.go:79: use -show-logs to present logs inline
    stream_replication_e2e_test.go:964: error executing 'RESUME JOB 824233434248249345': pq: job 824233434248249345: job with status succeeded cannot be resumed
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/90c1b75d835f45b8488807abb5b1092d/logTestTenantStreamingCutoverOnSourceFailure647287828
--- FAIL: TestTenantStreamingCutoverOnSourceFailure (5.27s)

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/tenant-streaming

This test on roachdash | Improve this report!

Jira issue: CRDB-22652
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Dec 21, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Dec 21, 2022
@stevendanna
Copy link
Collaborator

I think this is the result of the fact that COMPLETE REPLICATION now resumes the job for you, so the follow-up resume might happen after the job already completes.

@stevendanna stevendanna mentioned this issue Dec 22, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 25, 2023
@stevendanna @andyyang890 @ajwerner
Merge #94180 #95753 #95773 #95802 #95824
6fc1022 
94180: streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceFailure r=adityamaru a=stevendanna

    ALTER TENANT ... COMPLETE REPLICATION

resumes the job for the user, so there is no need to resume the job here. This does raise the question about whether or not it is the right behaviour to resume the job by default.

Fixes #94034

Release note: None

95753: roachtest: fix env var passing in activerecord test r=srosenberg a=andyyang890

This patch fixes the rails version pinning in the activerecord
roachtest. The rails version is passed in via the env variable
`RAILS_VERSION` and was previously being set before the `sudo`
in the adapter install command and thus erroneously discarded.

Informs #94211

Release note: None

95773: multiregionccl: add a missing log scope r=ajwerner a=ajwerner

Epic: none

Release note: None

95802: builtins: array_to_string should traverse nested arrays r=yuzefovich a=msirek

Fixes #95588

In Postgres, `array_to_string` traverses nested arrays and prints their contents. In CRDB, the nested array structures are printed out. For example,
`SELECT array_to_string(ARRAY[ARRAY[ARRAY[5,6], ARRAY[2,3]]], ' ');`

CRDB Result: `ARRAY[ARRAY[5:::INT8,6:::INT8],ARRAY[2:::INT8,3:::INT8]]` Postgres Result: `5 6 2 3`

This fix brings the behavior of `array_to_string` in line with Postgres, and avoids printing the nested ARRAY structures.

Some tools like GoldenGate rely on Postgres-compatible  behavior of `array_to_string` for proper functioning.

Release note (bug fix): This patch fixes the array_to_string built-in function so that nested arrays are traversed without printing 'ARRAY' at each nesting level.

95824: sql/execinfrapb: remove no-effect nullable from GenerativeSplitAndScatterSpec r=rhu713 a=rhu713

Remove no-effect nullable from GenerativeSplitAndScatterSpec that was causing warning messages during build.

Release note: None

Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
Co-authored-by: Mark Sirek <[email protected]>
Co-authored-by: Rui Hu <[email protected]>
@craig craig bot closed this as completed in 9e84744 Jan 25, 2023
Shivs11 pushed a commit to Shivs11/cockroach that referenced this issue Jan 30, 2023
@stevendanna @Shivs11
streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceF…
8818643 
…ailure

    ALTER TENANT ... COMPLETE REPLICATION

resumes the job for the user, so there is no need to resume the job
here. This does raise the question about whether or not it is the
right behaviour to resume the job by default.

Fixes cockroachdb#94034

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceFailure stevendanna/cockroach
2 participants
@stevendanna @cockroach-teamcity