Skip to content

Commit

Permalink
streamingccl: don't resume job in TestTenantStreamingCutoverOnSourceF…
Browse files Browse the repository at this point in the history
…ailure

    ALTER TENANT ... COMPLETE REPLICATION

resumes the job for the user, so there is no need to resume the job
here. This does raise the question about whether or not it is the
right behaviour to resume the job by default.

Fixes cockroachdb#94034

Release note: None
  • Loading branch information
stevendanna authored and Shivs11 committed Jan 30, 2023
1 parent 1f0aeb4 commit 8818643
Showing 1 changed file with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -590,9 +590,6 @@ func TestTenantStreamingCutoverOnSourceFailure(t *testing.T) {
cutoverOutput := replicationtestutils.DecimalTimeToHLC(t, cutoverStr)
require.Equal(c.T, cutoverTime, cutoverOutput)

// Resume ingestion.
c.DestSysSQL.Exec(t, fmt.Sprintf("RESUME JOB %d", ingestionJobID))

// Ingestion job should succeed despite source failure due to the successful cutover
jobutils.WaitForJobToSucceed(t, c.DestSysSQL, jobspb.JobID(ingestionJobID))
}
Expand Down

0 comments on commit 8818643

Please sign in to comment.