Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload/schemachange: intermittent failure on select statements #91445

Closed
fqazi opened this issue Nov 7, 2022 · 0 comments · Fixed by #91450
Closed

workload/schemachange: intermittent failure on select statements #91445

fqazi opened this issue Nov 7, 2022 · 0 comments · Fixed by #91450
Assignees
@fqazi
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented Nov 7, 2022 •
edited by cockroach-jira-scripts
Loading

Previously, we added code to handle memory budget and disk budget errors when selects were executed inside the randomized schema changer workloads since these can be expected for larger tables. Unfortunately, this detection logic was only limited to opening the result set, and not consuming the results, which can hit the same failure.

Jira issue: CRDB-21268
@fqazi fqazi added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-schema-deprecated Use T-sql-foundations instead branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Nov 7, 2022
@fqazi fqazi self-assigned this Nov 7, 2022
@fqazi fqazi changed the title workload/schemachange: intermittent failure on selects workload/schemachange: intermittent failure on select statements Nov 7, 2022
@fqazi fqazi mentioned this issue Nov 7, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 8, 2022
@ajwerner @maryliag
@yuzefovich @fqazi
Merge #91100 #91253 #91283 #91307 #91443 #91446 #91450
666fdee 
91100: logictest: only run create_as_non_metamorphic under local r=ajwerner a=ajwerner

This test is very expensive because it was writing 100Mib of data. It now writes more like 10. Nevertheless, let's not run it in so many places. I did verify that it still tests what it was intended to test.

Fixes #91080

Release note: None

91253: ui: fiz size chart when first load r=maryliag a=maryliag

Previously, the chart sizes were being properly
updated when resized, but the initial value was not correct.
This commit adds the call to handle resize so it
can load the correct size on first load.

Fix #91207

https://www.loom.com/share/3faf00b251e849d59120ce0b6e94047f

Release note: None

91283: ui: add horizontal scroll txn insight details r=maryliag a=maryliag

Previously, the table of "waiten on" inside the Transaction Insights details didn't have a horizontal scroll, not letting the user to see the full page on CC console. This commits adds the proper scroll to it.

Fixes #91199

Before
https://www.loom.com/share/80437381cd4546cfad9692c7718de38c

After
https://www.loom.com/share/7363d53bec1d49a0be1b90ab0c9069f2

Release note (bug fix): Add horizontal scroll on "waited on" table on Transaction Insight details page.

91307: scbuild: error on duplicate columns in ALTER PRIMARY KEY r=ajwerner a=postamar

This check has been missing from the declarative schema changer builder. This would result in execution errors in later stages when the new index makes it into the table descriptor. Since these are internal errors, the user experience is correspondingly poor. This patch fixes this.

Fixes #91301

Release note (bug fix): fixed a bug present only in earlier 22.2 release candidates, in which an ALTER PRIMARY KEY USING COLUMNS (x, x) statement would result in an internal error instead of the expected user-facing error with a pg-code.

91443: colexecop: remove stale TODO r=yuzefovich a=yuzefovich

This commit removes now-stale TODO about `Closer.Close` being safe to execute even after `Release` call. The root cause was the intertwining of planning and execution infrastructure and has been recently addressed in #89052.

Epic: None

Release note: None

91446: colexec: protect columnarizer when closing not started input r=yuzefovich a=yuzefovich

This commit makes sure that the columnarizer calls `InternalClose` only if it has been initialized. Previously, if `Columnarizer.Init` wasn't performed (most likely due to a panic in `Init` of another operator), the columnarizer's input would not be started, so when `InternalClose` called `input.ConsumerClosed`, that could lead to a nil pointer panic since `input.Ctx` would be `nil` if the input tried to do some logging (some processors do that). We now protect against this by short-circuiting `InternalClose` call altogether, similar to what we do in `Columnarizer.DrainMeta`. This makes it so that the columnarizer satisfies `Closer.Close` contract properly.

Fixes: #84902.

Release note: None

91450: workload/schemachange: address intermittent failures with select stmts r=fqazi a=fqazi

Fixes: #91445

Previously, we added logic to detect memory budget, and disk budget errors but those were only when opening a result set. Unfortunately, these errors can also be hit when consuming the rows themselves. To address this, this patch will detect the same errors and ignore them if detected consuming the result set.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
@craig craig bot closed this as completed in a66093a Nov 8, 2022
@blathers-crl blathers-crl bot mentioned this issue Nov 8, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Nov 8, 2022
@fqazi
workload/schemachange: address intermittent failures with select stmts
5d19640 
Fixes: #91445

Previously, we added logic to detect memory budget, and disk budget
errors but those were only when opening a result set. Unfortunately,
these errors can also be hit when consuming the rows themselves.
To address this, this patch will detect the same errors
and ignore them if detected consuming the result set.

Release note: None
fqazi added a commit that referenced this issue Nov 9, 2022
@fqazi
workload/schemachange: address intermittent failures with select stmts
9a226bb 
Fixes: #91445

Previously, we added logic to detect memory budget, and disk budget
errors but those were only when opening a result set. Unfortunately,
these errors can also be hit when consuming the rows themselves.
To address this, this patch will detect the same errors
and ignore them if detected consuming the result set.

Release note: None
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload/schemachange: address intermittent failures with select stmts fqazi/cockroach
1 participant
@fqazi