Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fiz size chart when first load #91253

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Nov 3, 2022

Previously, the chart sizes were being properly
updated when resized, but the initial value was not correct.
This commit adds the call to handle resize so it
can load the correct size on first load.

Fix #91207

https://www.loom.com/share/3faf00b251e849d59120ce0b6e94047f

Release note: None

Previously, the chart sizes were being properly
updated when resized, but the initial value was not
correct.
This commit adds the call to handle resize so it
can load the correct size on first load.

Fix cockroachdb#91207

Release note: None
@maryliag maryliag requested a review from a team November 3, 2022 22:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag
Copy link
Contributor Author

maryliag commented Nov 7, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed:

@maryliag
Copy link
Contributor Author

maryliag commented Nov 8, 2022

bors r+

@craig craig bot merged commit 666fdee into cockroachdb:master Nov 8, 2022
@craig
Copy link
Contributor

craig bot commented Nov 8, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Statement Details charts overlap on first load
3 participants