server: make CreateStatementDiagnosticsReport tenant-scoped #90274
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
THardy98
added
C-enhancement
craig bot
pushed a commit
that referenced
this issue
Nov 10, 2022
91081: ui: migrate statement diagnostics requests to use sql-over-http endpoint r=THardy98 a=THardy98 Part of: #89429 Addresses: #90273, #90274, #90275 Blocked from resolving by #80789 DB-Console Demo: https://www.loom.com/share/d74c02eb3dfb41fc913577d0e8992441 CC-Console Demo: https://www.loom.com/share/2adba8a53b8c48ac9f031e4481f284cf This change migrates the existing statement diagnostics requests to use the sql-over-http endpoint on our apiV2, making these requests tenant-scoped once the sql-over-http endpoint is scoped to tenants (this should be the case when #91323 is completed). 91534: lint: remove Golint r=yuzefovich a=yuzefovich This commit removes `TestGolint` linter as well as all mentions of `golint` I could find. The rationale is that - the linter is no longer maintained - is partially duplicated with the `staticcheck` - due to a recent change in `gcexportdata.Find`, if we bump some dependencies, it takes on the order of an hour when run via bazel, and we'd need to fork `golint` to go around that. Epic: None Release note: None 91626: kvstreamer: improve the behavior with very low budget r=yuzefovich a=yuzefovich This commit makes it so that the streamer tries a bit harder to not hit its low budget limit in `Enqueue`. Previously, due to some of the internal state being reused across different `Enqueue` batches (in particular, the truncation helper as well as some things in the results buffer), the streamer's budget might be insufficient to account for the newly-enqueued requests, and we would error out. This commit makes it so that - if the budget limit is reached - we first discard the overhead (freeing up some budget) and then try to consume the requests' footprint again. This shouldn't be a big deal with reasonably large workmem limits, but we have seen some problems when it is on the order of 100KiB or less. Fixes: #91587. Release note: None 91662: multi-tenant: Bump uninitialized storage cluster version r=knz a=ajstorm Previously, in cases where the version value in system.tenant_settings was uninitialized, we assumed that that the version was 22.1. With the change of the build tag to 23.1, we need to adjust the previous version to 22.1.76. This will need one more bump when we finally mint the 22.2 version number in master. Resolves: #91589 Release note: None Co-authored-by: Thomas Hardy <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Adam Storm <[email protected]>
|
Closed with the merge of #91081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Part of: #89429
As part of our effort to migrate to a multi-tenant architecture, we need to ensure our existing create statement diagnostics report endpoint is tenant-scoped.
Fortunately, the existing endpoint is implemented using SQL, meaning the remaining work to be done is implementing the same endpoint for our
tenantAdminServer(alternatively, we can use the sql-over-http endpoint: #79663, which will become tenant-scoped with the completion of #80789).Reference PR: #84620, making the
JobsandJobendpoints tenant-scopedJira issue: CRDB-20670
The text was updated successfully, but these errors were encountered: