lint: remove Golint #91534
Merged
lint: remove Golint #91534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Some discussion here. |
yuzefovich
force-pushed
the
remove-golint
branch
2 times, most recently
from
7e182ad to
906fa89
Compare
yuzefovich
force-pushed
the
remove-golint
branch
from
906fa89 to
e865b69
Compare
|
Looks like no one is relying on TFTRs! bors r+ |
|
I think there is a merge conflict with an in-flight #91616, so I'll let that change go in first. bors r- |
|
Canceled. |
This commit removes `TestGolint` linter as well as all mentions of `golint` I could find. The rationale is that - the linter is no longer maintained - is partially duplicated with the `staticcheck` - due to a recent change in `gcexportdata.Find`, if we bump some dependencies, it takes on the order of an hour when run via bazel, and we'd need to fork `golint` to go around that. Epic: None Release note: None
yuzefovich
force-pushed
the
remove-golint
branch
from
e865b69 to
f00ca3c
Compare
|
bors r+ |
|
Build succeeded: |
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
TestGolintlinter as well as all mentions ofgolintI could find. The rationale is thatstaticcheckgcexportdata.Find, if we bump some dependencies, it takes on the order of an hour when run via bazel, and we'd need to forkgolintto go around that.Epic: None
Release note: None