Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: gorm failed #83885

Closed
cockroach-teamcity opened this issue Jul 6, 2022 · 3 comments · Fixed by #84188
Closed

roachtest: gorm failed #83885

cockroach-teamcity opened this issue Jul 6, 2022 · 3 comments · Fixed by #84188
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
21.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 6, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.gorm failed with artifacts on release-21.2 @ 02d41faffca57ae50518a5729e574050edf125e1:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/gorm/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,gorm.go:132,test_runner.go:777: 
		Tests run on Cockroach v21.2.13-24-g02d41faffc-dirty
		Tests run against gorm v1.23.7
		1 Total Tests Run
		0 tests passed
		1 test failed
		0 tests skipped
		0 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.[build failed] - unknown (unexpected)
		For a full summary look at the gorm artifacts 
		
		An updated blocklist (gormBlocklist21_2) is available in the artifacts' gorm log
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-17331
@cockroach-teamcity cockroach-teamcity added branch-release-21.2 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jul 6, 2022
@cockroach-teamcity cockroach-teamcity added this to the 21.2 milestone Jul 6, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 6, 2022
@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jul 6, 2022
This was referenced Jul 7, 2022
Closed
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.gorm failed with artifacts on release-21.2 @ a66eb33e57e8ad063101a5c7d5cb094ece8b62d6:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/gorm/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,gorm.go:132,test_runner.go:777: 
		Tests run on Cockroach v21.2.13-30-ga66eb33e57
		Tests run against gorm v1.23.8
		1 Total Tests Run
		0 tests passed
		1 test failed
		0 tests skipped
		0 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.[build failed] - unknown (unexpected)
		For a full summary look at the gorm artifacts 
		
		An updated blocklist (gormBlocklist21_2) is available in the artifacts' gorm log
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.gorm failed with artifacts on release-21.2 @ 3ee788ae1661aa92e1ece39f0c01cf6ebd469c44:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/gorm/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,gorm.go:132,test_runner.go:777: 
		Tests run on Cockroach v21.2.13-36-g3ee788ae16
		Tests run against gorm v1.23.8
		1 Total Tests Run
		0 tests passed
		1 test failed
		0 tests skipped
		0 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.[build failed] - unknown (unexpected)
		For a full summary look at the gorm artifacts 
		
		An updated blocklist (gormBlocklist21_2) is available in the artifacts' gorm log
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.gorm failed with artifacts on release-21.2 @ bce163fd3a462bc778405fb371470371d214e758:

The test failed on branch=release-21.2, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/gorm/run_1
	orm_helpers.go:245,orm_helpers.go:171,java_helpers.go:220,gorm.go:132,test_runner.go:777: 
		Tests run on Cockroach v21.2.13-42-gbce163fd3a
		Tests run against gorm v1.23.8
		1 Total Tests Run
		0 tests passed
		1 test failed
		0 tests skipped
		0 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: tests.[build failed] - unknown (unexpected)
		For a full summary look at the gorm artifacts 
		
		An updated blocklist (gormBlocklist21_2) is available in the artifacts' gorm log
Reproduce

See: roachtest README

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

@ZhouXing19 ZhouXing19 mentioned this issue Jul 11, 2022
Merged
craig bot pushed a commit that referenced this issue Jul 11, 2022
@Xiang-Gu @yuzefovich
@msbutler @mgartner @ZhouXing19
Merge #83719 #83958 #83984 #84049 #84097 #84143 #84169 #84188
10853d2 
83719: storage: remove dependency to sql/catalog/bootstrap r=Xiang-Gu a=Xiang-Gu

Previously, tests in `pkg/storage` depended on `sql/catalog/bootstrap`.
This was inadequate/weird because `storage` is a much lower layer in the
architectural stack. It will also help prevent dependency cycles in
other PRs when we introduce depencies (see #82172 if interested).

Release note: None

83958: colexecbase: add all remaining casts from strings r=yuzefovich a=yuzefovich

**tree: minor cleanup**

This commit does a few minor things:
- actually uses the error in a few places when constructing a ParseError
- refactors some of the interval-parsing functions to expose them to be
used in the follow-up commit
- extracts a helper method to construct an error when timestamp exceeds
bounds.

Release note: None

**colexecbase: sort native cast info lexicographically**

This commit sorts the information about natively supported casts
lexicographically so that it is easier to see what is actually
supported. This is simply a mechanical change.

Release note: None

**colexecbase: add all remaining casts from strings**

This commit adds the native casts from strings to all remaining
natively-supported types (dates, decimals, floats, ints, intervals,
timestamps, jsons).

I was inspired to do this because the combination of this
commit and the vectorized rendering on top of the wrapped row-by-row
processors would expose some bugs (e.g. #83094).

Addresses: #48135.

Release note: None

83984: storageccl: use NewPebbleIterator in restore data processor r=erikgrinaker a=msbutler

This PR replaces the multiIterator used in the restore data processor with the
PebbleSSTIterator, which has baked in range key support.

This patch is apart of a larger effort to teach backup and restore about MVCC
bulk operations. Next, the readAsOfIterator will need to learn how to
deal with range keys.

Informs #71155

Release note: none

84049: sql: fix memory accounting of prepared statements and portals in error cases r=yuzefovich a=yuzefovich

**sql: make sure to close mem acc of prepared stmt in case of an error**

Previously, it was possible that we would not close the memory account
created for a prepared statement when an error is encountered. This was
the case because we would not include the prepared stmt into the prep
stmts namespace, so it would just get lost. However, up until recently
this was not an issue since we mistakenly cleared that memory account
when creating the prepared statement.

Release note: None

**sql: only increment ref count of prep stmt in non-error case of portals**

Previously, it was possible to "leak" a reference to a prepared
statement if we made a portal from it (i.e. took a reference to the
prepared statement) and the memory reservation was denied. This could
lead to "leftover bytes" errors when stopping the "session" monitors.
However, the impact is minor because on release builds we'd still return
those "leftover bytes" and would just file a sentry issue. This is now
fixed.

Fixes: #83935

Release note: None

84097: DOC-4899: Remove linking on subdirectory from show_backup diagram r=RichardJCai a=nickvigilante

Release note: None

84143: Revert "kvstreamer: reuse incomplete Get requests on resume batches" r=yuzefovich a=yuzefovich

This reverts commit 21f2390.

Previously, I didn't realize that the KV layer would modify all requests
included into the BatchRequest in `txnSeqNumAllocator`, so we cannot
reuse even incomplete GetRequests. It is unfortunate, but not a big
deal.

Fixes: #83974.

Release note: None

84169: opt: fix incorrect column indexing in index recommendations r=mgartner a=mgartner

#### opt: fix incorrect column indexing in index recommendations

Fixes #83965

Release note (bug fix): A minor bug has been fixed that caused internal
errors and poor index recommendations when running `EXPLAIN` statements.

#### opt: clarify logic in Metadata.UpdateTableMeta

Release note: None


84188: roachtest: update supported tag for gorm r=ZhouXing19 a=ZhouXing19

fixes #83794
fixes #83797
fixes #83885

Release note: None

Co-authored-by: Xiang Gu <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Nick Vigilante <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Jane Xing <[email protected]>
@craig craig bot closed this as completed in 0f623d6 Jul 11, 2022
ZhouXing19 added a commit to ZhouXing19/cockroach that referenced this issue Jul 12, 2022
@ZhouXing19
release-22.1: roachtest: update gorm support tag
8577d24 
Backport 1/1 commits from cockroachdb#84188 on behalf of @ZhouXing19.

/cc @cockroachdb/release

fixes cockroachdb#83794
fixes cockroachdb#83797
fixes cockroachdb#83885

Release note: None

Release justification: fix roachtest with gorm
@ZhouXing19 ZhouXing19 mentioned this issue Jul 12, 2022
Merged
ZhouXing19 added a commit to ZhouXing19/cockroach that referenced this issue Jul 12, 2022
@ZhouXing19
release-21.2: roachtest: update gorm support tag
450e3c5 
Backport 1/1 commits from cockroachdb#84188 on behalf of @ZhouXing19.

/cc @cockroachdb/release

fixes cockroachdb#83794
fixes cockroachdb#83797
fixes cockroachdb#83885

Release note: None

Release justification: fix roachtest with gorm
@ZhouXing19 ZhouXing19 mentioned this issue Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
21.2
Development

Successfully merging a pull request may close this issue.

roachtest: update supported tag for gorm ZhouXing19/cockroach
2 participants
@rafiss @cockroach-teamcity