Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: fix incorrect column indexing in index recommendations #84169

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

mgartner
Copy link
Collaborator

opt: fix incorrect column indexing in index recommendations

Fixes #83965

Release note (bug fix): A minor bug has been fixed that caused internal
errors and poor index recommendations when running EXPLAIN statements.

opt: clarify logic in Metadata.UpdateTableMeta

Release note: None

mgartner added 2 commits July 11, 2022 08:38
Fixes cockroachdb#83965

Release note (bug fix): A minor bug has been fixed that caused internal
errors and poor index recommendations when running `EXPLAIN` statements.
@mgartner mgartner requested a review from a team as a code owner July 11, 2022 12:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner requested review from rytaft and cucaroach July 11, 2022 12:45
@mgartner mgartner requested review from msirek and wenyihu6 and removed request for cucaroach July 11, 2022 12:52
Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft and @wenyihu6)

@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@mgartner
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 11, 2022

Build succeeded:

@craig craig bot merged commit 10853d2 into cockroachdb:master Jul 11, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jul 11, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f678273 to blathers/backport-release-22.1-84169: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing by EXPLAIN Statement
3 participants