Insights: Drop unused index + Schema tab #83829
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
kevin-v-ngo
added
the
C-enhancement
Closed
craig bot
pushed a commit
that referenced
this issue
Aug 25, 2022
85986: sql: make copy atomic by default and add optin to old behavior r=cucaroach a=cucaroach Previously COPY under and implicit transaction would use auto committed batches of 100 rows. This decision was made years ago when large txn support wasn't what it is now. Today we handle large transactions better so make the default bahavior atomic and provide a cluster setting to get back the old behavior. Its possible in busy clusters with large COPY's there may be contention and retries that make non-atomic copy desirable. Fixes: #85887 Release note (sql change): COPY FROM operations are now atomic by default instead of being segmented into 100 row transactions. Setting the sql.copyfrom.atomic cluster setting to false to get the old behavior. Release justification: low risk high benefit correctness fix to existing functionality 86189: storage/metamorphic: add TestCompareFiles r=nicktrav a=jbowens Add a new MVCC metamorphic test entrypoint, TestCompareFiles, that takes a check file through `--check` and one or more output.metas through `--compare-files`. The test runs the configurations specified through `--compare-files` against the specified `--check` file, parsing out the encoded Pebble options. Release note: None Release justification: Non-production code changes 86317: ui: introduce schema insights page on db-console r=THardy98 a=THardy98 Resolves: #83828, [#83829](#83829) This change introduces the schema insights page to the DB-Console. Schema insights are fetched from `schemaInsightsApi` using the SQL-over HTTP API and the corresponding component `schemaInsightsView` is available from cluster-ui for future use in the CC console. The schema insights page display a table of schema insights - currently different types of index recommendations (i.e. drop/create/replace index recommendations), with the intention to add different types of schema insights in the future. Each schema insight row offers an actionable button, offering the user the ability to execute the corresponding SQL query that realizes their schema insight. Filters are available to filter by database and the schema insight type, as well as search. ~~Loom: https://www.loom.com/share/29ac973730614968893c179f4974fc61~~ Updated Loom: https://www.loom.com/share/ee36842fa9594c8888523d9ce41e1607 (this demo shows a known bug in the duration formatting on the index details page when the duration is set to <1 hour, #85222) Release note (ui change): Added new Schema Insights page to DB Console. The Schema Insights page displays a table of schema insights - currently different types of index recommendations (i.e. drop/create/replace index recommendations). Each schema insight row offers the user the ability to execute the corresponding SQL query that realizes their schema insight via a clickable button. Filters are available to filter the surfaced schema insights by database and insight type, as well as search. Release justification: low risk, high benefit changes to existing functionality Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Thomas Hardy <[email protected]>
|
@THardy98 can this be closed? |
|
Yes I believe so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks surfacing a Drop Unused Index insight on the Insights page including the Schema tab.
Related issue
Link to figma
FYI @Annebirzin
Jira issue: CRDB-17287
The text was updated successfully, but these errors were encountered: