storage/metamorphic: add TestCompareFiles #86189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jbowens
force-pushed
the
metamorphic-compare-files
branch
from
be07895 to
aa98c81
Compare
nicktrav
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @jbowens)
pkg/storage/metamorphic/meta_test.go line 335 at r1 (raw file):
// --test-args '--compare-files=/Users/craig/archive/random8.meta' // // The above example supples `--in-mem`. This may be useful to produce quick
nit: supplies
Add a new MVCC metamorphic test entrypoint, TestCompareFiles, that takes a check file through `--check` and one or more output.metas through `--compare-files`. The test runs the configurations specified through `--compare-files` against the specified `--check` file, parsing out the encoded Pebble options. Release note: None Release justification: Non-production code changes
jbowens
force-pushed
the
metamorphic-compare-files
branch
from
aa98c81 to
d290dc5
Compare
|
TFTR! bors r=nicktrav |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new MVCC metamorphic test entrypoint, TestCompareFiles, that takes a
check file through
--checkand one or more output.metas through--compare-files. The test runs the configurations specified through--compare-filesagainst the specified--checkfile, parsing out the encodedPebble options.
Release note: None
Release justification: Non-production code changes