-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: can't run dev builder
without many unnecessary prereqs
#82444
Comments
#82522 will take care of the requirement to run
This is exactly right. I didn't know that people were having trouble getting bazel (bazelisk) installed. The |
The `doctor` checks aren't really needed here. Part of cockroachdb#82444. Release note: None
Even figuring out that there is such a thing as |
81325: DOC-3097: Updated SQL diagrams for SHOW DEFAULT PRIVILEGES r=RichardJCai a=nickvigilante Fixes DOC-3097 Release note: None 82348: sql: COPY benchmark roachtest r=cucaroach a=cucaroach Simple roachtest benchmark performing a single node copy of a 750k line CSV (TPCH lineitem table). On my gceworker CRDB does it in 5773 rows/s and PG does it in 36945 rows/s. Fixes: #82348 Release note: none 82522: dev: skip `doctor` check for `dev builder` or `dev help` r=rail a=rickystewart The `doctor` checks aren't really needed here. Part of #82444. Release note: None Co-authored-by: Nick Vigilante <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
The `doctor` checks aren't really needed here. Part of #82444. Release note: None
We have a bazel builder container whose purpose is, I believe, to let people build CRDB without having to install stuff on their local system. In practice, however, getting to that container requires installing all sorts of things, which defeats its purpose. The intended way to run this container is, I believe,
dev container
. But:dev
requiresbazel
to be installed in order to run anything - includingdev help
anddev builder
. Installing bazel is a pain. I think this requirement comes from dev-the-shell-script needingbazel
in order to build dev-the-binary.dev doctor
needs to pass once before any other dev subcommand works - again, includingdev help
anddev builder
. Ifdev doctor
never passed before, you get messages about howdev doctor
's status needs to be updated.dev doctor
requires acmake
upgrade, making it a big pain and again defeating the purpose of the container.I failed to run the
cockroachdb/bazel
container by hand, with Docker but without going throughdev
. The first problem is that we don't seem to have alatest
tag applied to the container images. Even when using a image id, I failed to run the container because of someroot
issue. I haven't looked into howdev builder
does it.Filing this after looking over @ipopov's shoulder trying to build crdb for the first time.
Jira issue: CRDB-16388
Epic CRDB-17171
The text was updated successfully, but these errors were encountered: