sql: COPY benchmark roachtest #82348
Conversation
|
This change is |
| c, | ||
| c.All(), | ||
| "install dependencies", | ||
| `sudo apt-get install -qq postgresql`, |
There was a problem hiding this comment.
do you think it's worth using a stable postgresql version?
There was a problem hiding this comment.
I can't think of a reason why, ubuntu LTS should be stable enough no? Open to suggestions...
There was a problem hiding this comment.
In the past we've found that the package archive updates the versions if you do sudo apt-get install and then you get result changes that don't correlate.
If you wanted to be a bit more particular I'd install from source, but I am not going to hold this pr down for it.
pkg/cmd/roachtest/tests/copyfrom.go
Outdated
| t.L().Printf("%v\n", det.Stderr) | ||
| t.Fatal(err) | ||
| } | ||
| dur := time.Since(start) |
There was a problem hiding this comment.
should this line live above if err != nil
There was a problem hiding this comment.
Why? I like the err handling cuddled as close to source of error as possible.
There was a problem hiding this comment.
Doesn't it add extra duration time technically :P? The if err! =nil adds an extra nanosecond or two, haha
Simple roachtest benchmark performing a single node copy of a 750k line CSV (TPCH lineitem table). On my gceworker CRDB does it in 5773 rows/s and PG does it in 36945 rows/s. Fixes: cockroachdb#81725 Release note: none
|
TFTR! bors r+ |
|
Build succeeded: |
Simple roachtest benchmark performing a single node copy of a 750k line
CSV (TPCH lineitem table). On my gceworker CRDB does it in 5773 rows/s
and PG does it in 36945 rows/s.
Fixes: #82348
Release note: none