Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: activerecord failed #82198

Closed
cockroach-teamcity opened this issue Jun 1, 2022 · 0 comments · Fixed by #82292
Closed

roachtest: activerecord failed #82198

cockroach-teamcity opened this issue Jun 1, 2022 · 0 comments · Fixed by #82292
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 1, 2022

roachtest.activerecord failed with artifacts on master @ 1cea73c8a18623949b81705eb5f75179e6cd8d86:

		  |                           initialize submodules in the clone
		  |     -j, --jobs <n>        number of submodules cloned in parallel
		  |     --template <template-directory>
		  |                           directory from which templates will be used
		  |     --reference <repo>    reference repository
		  |     --reference-if-able <repo>
		  |                           reference repository
		  |     --dissociate          use --reference only while cloning
		  |     -o, --origin <name>   use <name> instead of 'origin' to track upstream
		  |     -b, --branch <branch>
		  |                           checkout <branch> instead of the remote's HEAD
		  |     -u, --upload-pack <path>
		  |                           path to git-upload-pack on the remote
		  |     --depth <depth>       create a shallow clone of that depth
		  |     --shallow-since <time>
		  |                           create a shallow clone since a specific time
		  |     --shallow-exclude <revision>
		  |                           deepen history of shallow clone, excluding rev
		  |     --single-branch       clone only one branch, HEAD or --branch
		  |     --no-tags             don't clone any tags, and make later fetches not to follow them
		  |     --shallow-submodules  any cloned submodules will be shallow
		  |     --separate-git-dir <gitdir>
		  |                           separate git dir from working tree
		  |     -c, --config <key=value>
		  |                           set config inside the new repository
		  |     --server-option <server-specific>
		  |                           option to transmit
		  |     -4, --ipv4            use IPv4 addresses only
		  |     -6, --ipv6            use IPv6 addresses only
		  |     --filter <args>       object filtering
		  |     --remote-submodules   any cloned submodules will use their remote-tracking branch
		  |     --sparse              initialize sparse-checkout file to include only files at root
		  |
		  |
		  | stdout:
		Wraps: (8) COMMAND_PROBLEM
		Wraps: (9) Node 1. Command with error:
		  | ``````
		  | bash -e -c '
		  | 		if ! test -d /mnt/data1/activerecord-cockroachdb-adapter; then
		  | 			git clone -b v6.1.10 --depth 1 https://github.com/cockroachdb/activerecord-cockroachdb-adapter.git /mnt/data1/activerecord-cockroachdb-adapter --add safe.directory /mnt/data1/activerecord-cockroachdb-adapter
		  |   		else
		  | 			cd /mnt/data1/activerecord-cockroachdb-adapter
		  | 		git fetch origin
		  | 		git checkout origin/v6.1.10
		  |   		fi
		  |   		'
		  | ``````
		Wraps: (10) exit status 129
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.withPrefix (5) *withstack.withStack (6) *errutil.withPrefix (7) *cluster.WithCommandDetails (8) errors.Cmd (9) *hintdetail.withDetail (10) *exec.ExitError
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-16244

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 1, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jun 1, 2022
@ZhouXing19 ZhouXing19 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jun 1, 2022
@ZhouXing19 ZhouXing19 self-assigned this Jun 1, 2022
craig bot pushed a commit that referenced this issue Jun 1, 2022
75625: rfcs: partial statistics collection r=rytaft a=mgartner

Release note: None

81997: colexecspan: optimize some allocations r=yuzefovich a=yuzefovich

**bench: add benchmark of index joins on a table with two column families**

Release note: None

**colexecspan: optimize some allocations**

This commit pre-allocates a large byte slice for all column-family
specific spans for a single row, reducing the number of allocations. It
also removes an unnecessary allocation in a single-column family case
for `EndKey` - `PrefixEnd` itself already allocates memory.
```
name                                           old time/op    new time/op    delta
IndexJoinColumnFamilies/Cockroach-24             8.98ms ± 4%    8.96ms ± 3%    ~     (p=0.631 n=10+10)
IndexJoinColumnFamilies/MultinodeCockroach-24    12.3ms ± 4%    12.4ms ± 5%    ~     (p=0.971 n=10+10)

name                                           old alloc/op   new alloc/op   delta
IndexJoinColumnFamilies/Cockroach-24             1.72MB ± 1%    1.71MB ± 1%  -0.59%  (p=0.000 n=10+10)
IndexJoinColumnFamilies/MultinodeCockroach-24    2.58MB ± 1%    2.56MB ± 3%    ~     (p=0.218 n=10+10)

name                                           old allocs/op  new allocs/op  delta
IndexJoinColumnFamilies/Cockroach-24              13.9k ± 1%     12.9k ± 0%  -7.41%  (p=0.000 n=10+10)
IndexJoinColumnFamilies/MultinodeCockroach-24     19.6k ± 1%     18.6k ± 1%  -5.21%  (p=0.000 n=10+9)
```

Release note: None

82190: sql: omit dropped columns from SHOW STATISTICS output r=msirek a=msirek

Fixes #76573

Previously, statistics on dropped columns were displayed in `SHOW
STATISTICS [USING JSON]` output.

This was inadequate because statement bundle scripts with
`ALTER TABLE ... INJECT STATISTICS` statements, generated via
`SHOW STATISTICS USING JSON` output, required manual editing
in order to run successfully if the table in question had a dropped
column.

To address this, this patch omits printing of statistics involving
dropped columns in `SHOW STATISTICS` output, including multicolumn
statistics.

Release note (bug fix): This fixes SHOW STATISTICS output so statistics
involving dropped columns are not displayed.

82292: roachtest: fix safe.directory requirement for git config r=srosenberg a=ZhouXing19

The previous fix (#82145) was wrong and is breaking multiple roachtests.

fixes #82198
fixes #82199
fixes #82205
fixes #82207
fixes #82215
fixes #82225
fixes #82224
fixes #82247
fixes #82258
fixes #82261
fixes #82262
fixes #82263
fixes #82264
fixes #82265
fixes #82267
fixes #82268
fixes #82269

Release note: None

82297: dev: add `doctor` check for `patch` version r=sjbarag a=rickystewart

The UI build has been broken on most Macs since
`5b6c271b1cd78323ac11cde677834d4918c183f4`, as parsing the patch files
introduced in that commit requires a later version of GNU patch than
gets installed on macOS by default. Add a `doctor` check to make sure
that the `patch` at the head of the `PATH` is v2.7+.

Release note: None

Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Mark Sirek <[email protected]>
Co-authored-by: Jane Xing <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 6b29a83 Jun 1, 2022
@craig craig bot closed this as completed in #82292 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants