colexecspan: optimize some allocations #81997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Hold off on reviewing for now, there seem to be some legitimate failures. |
Release note: None
This commit pre-allocates a large byte slice for all column-family specific spans for a single row, reducing the number of allocations. It also removes an unnecessary allocation in a single-column family case for `EndKey` - `PrefixEnd` itself already allocates memory. ``` name old time/op new time/op delta IndexJoinColumnFamilies/Cockroach-24 8.98ms ± 4% 8.96ms ± 3% ~ (p=0.631 n=10+10) IndexJoinColumnFamilies/MultinodeCockroach-24 12.3ms ± 4% 12.4ms ± 5% ~ (p=0.971 n=10+10) name old alloc/op new alloc/op delta IndexJoinColumnFamilies/Cockroach-24 1.72MB ± 1% 1.71MB ± 1% -0.59% (p=0.000 n=10+10) IndexJoinColumnFamilies/MultinodeCockroach-24 2.58MB ± 1% 2.56MB ± 3% ~ (p=0.218 n=10+10) name old allocs/op new allocs/op delta IndexJoinColumnFamilies/Cockroach-24 13.9k ± 1% 12.9k ± 0% -7.41% (p=0.000 n=10+10) IndexJoinColumnFamilies/MultinodeCockroach-24 19.6k ± 1% 18.6k ± 1% -5.21% (p=0.000 n=10+9) ``` Release note: None
michae2
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bench: add benchmark of index joins on a table with two column families
Release note: None
colexecspan: optimize some allocations
This commit pre-allocates a large byte slice for all column-family
specific spans for a single row, reducing the number of allocations. It
also removes an unnecessary allocation in a single-column family case
for
EndKey-PrefixEnditself already allocates memory.Release note: None