Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: failure to run ./dev generate bazel should be reported as a test failure to TeamCity #78368

Closed
rickystewart opened this issue Mar 23, 2022 · 0 comments · Fixed by #78433
Closed

ci: failure to run ./dev generate bazel should be reported as a test failure to TeamCity #78368

rickystewart opened this issue Mar 23, 2022 · 0 comments · Fixed by #78433
Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Mar 23, 2022 •
edited by cockroach-jira-scripts
Loading

Internal discussion

Currently a failure to run ./dev generate bazel is reported in TeamCity via the script build/teamcity/ci/tests/check_generated_code_impl.sh, specifically via check_workspace_clean in build/teamcity-support.sh. Currently if there is a failure we just write the message to stderr and exit 1, but we could log this as a test failure to TeamCity via ##teamcity[testFailed name='%s' details='%s' flowId='%s']".

Epic CRDB-8306

Jira issue: CRDB-14093
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf A-ci Continuous Integration labels Mar 23, 2022
@rickystewart rickystewart mentioned this issue Mar 24, 2022
Merged
craig bot pushed a commit that referenced this issue Mar 28, 2022
@cameronnunez @rickystewart
@rharding6373 @tbg @nicktrav
Merge #76516 #78433 #78495 #78525 #78561 #78602 #78617 #78629
f8e03e2 
76516: server: improve visibility of ranges that fail to move during decommissioning r=knz,aayushshah15 a=cameronnunez

Fixes #76249. Informs #74158.

This patch makes it so that when a decommission is slow or stalls, the 
descriptions of some "stuck" replicas are printed to the operator.

Release note (cli change): if decommissioning is slow or stalls, decommissioning
replicas are printed to the operator.

Release justification: low risk, high benefit changes to existing functionality

78433: ci: report failure to generate code as a test failure to teamcity r=rail a=rickystewart

Closes #78368.

Release note: None

78495: cluster: Revert "cluster: use WaitConditionNextExit" r=otan a=rickystewart

This reverts commit 6543749.
That commit was an (unsuccessful) attempt to fix #58955, and in the
presence of this change the `acceptance` tests are very likely to hang
forever under Ubuntu 20.04 due to a race condition where the container
exits before we begin waiting on it.

Release note: None

78525: dev: add `ui clean` subcommand, update `Makefile` to point to `dev` r=rail a=rickystewart

Add `ui clean` and `ui clean --all`; the former does approximately the
same as `make ui-clean`, the latter does approximately the same as
`make ui-maintainer-clean`.

Release note: None

78561: sqlsmith: fix deadlock during generation r=rharding6373 a=rharding6373

Fixes a deadlock when sqlsmith generates join expressions.

Fixes: #78555

Release note: None

78602: roachpb,kvserver: tweak ReplicaUnavailableError rendering r=erikgrinaker a=tbg

Release justification: minor UX tweakto an error message
Release note: None


78617: roachtest: wait for 3x replication in disk-full r=tbg a=nicktrav

Improve on #78456 by waiting fro 3x replication, rather than 2x.

Release note: None.

78629: ci: make sure we're streaming test output when `stress`ing via Bazel r=mari-crl a=rickystewart

Without this, you don't see the helpful "ran X iterations so far, Y
failures" messages from `stress`.

Release note: None

Co-authored-by: Cameron Nunez <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
Co-authored-by: rharding6373 <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: Nick Travers <[email protected]>
@craig craig bot closed this as completed in 37d3c8c Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ci Continuous Integration C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: report failure to generate code as a test failure to teamcity rickystewart/cockroach
1 participant
@rickystewart