cluster: Revert "cluster: use WaitConditionNextExit" #78495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6543749. That commit was an (unsuccessful) attempt to fix cockroachdb#58955, and in the presence of this change the `acceptance` tests are very likely to hang forever under Ubuntu 20.04 due to a race condition where the container exits before we begin waiting on it. Release note: None
|
This change is |
|
Lgtm
(sent from mobile, please excuse my brevity)
…On Fri, Mar 25, 2022, 15:34 cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/78495>
—
Reply to this email directly, view it on GitHub
<#78495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGXPZA2QYPG4RNE4NRXUUTVBXFHXANCNFSM5RUKSVMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
otan
approved these changes
Mar 27, 2022
|
TFTR! bors r=otan |
|
Build succeeded: |
|
blathers backport 21.2 22.1 |
This was referenced Mar 28, 2022
|
blathers backport 21.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6543749.
That commit was an (unsuccessful) attempt to fix #58955, and in the
presence of this change the
acceptancetests are very likely to hangforever under Ubuntu 20.04 due to a race condition where the container
exits before we begin waiting on it.
Release note: None