sql: when a table drops a bunch of columns saved gists will runtime panic on decode #76800
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-queries
SQL Queries Team
Comments
cucaroach
added
the
C-bug
cucaroach
added a commit
to cucaroach/cockroach
that referenced
this issue
Feb 19, 2022
Previously we didn't guard against out of bounds column ids in gists,
if a gist is created on a table and then that table drops columns we
would hit a runtime index out of bounds panic. By design gist decoding
is best effort and should silently ignore these columns when this
happens. The columns are used for equality conditions, ie:
└── • lookup join
│ table: broker@broker_pkey
│ equality: (tr_s_symb) = (b_id)
So they are a nice to have. Doing anything more sophisticated would
dramatically increase the gist size so isn't worth it.
Fixes: cockroachdb#76800
Release note: None
craig bot
pushed a commit
that referenced
this issue
Feb 23, 2022
76606: spanconfigsqltranslator: emit all SystemTarget span configs when required r=arulajmani a=adityamaru This change teaches the SQLTranslator to emit SpanConfigurations corresponding to `spanconfig.SystemTargets`. Today, these SpanConfigurations only contain ProtectionPolicies, corresponding to protected timestamp records that may be written by the host tenant to protect its cluster, a secondary tenant to protect its cluster, or the host tenant to protect a secondary tenant. The SystemTarget span configurations will be applied to a SystemSpanConfig store that will be introduced in a follow up PR. Informs: #73727 Release note: None 76801: sql: fix cached gists panic'ing after schema changes r=mgartner a=cucaroach Previously we didn't guard against out of bounds column ids in gists, if a gist is created on a table and then that table drops columns we would hit a runtime index out of bounds panic. By design gist decoding is best effort and should silently ignore these columns when this happens. The columns are used for equality conditions, ie: └── • lookup join │ table: broker@broker_pkey │ equality: (tr_s_symb) = (b_id) So they are a nice to have. Doing anything more sophisticated would dramatically increase the gist size so isn't worth it. Fixes: #76800 Release note: None 76900: mon: when creating inherited BytesMonitor don't copy metrics r=yuzefovich a=aliher1911 Previously monitor inherited parameters like name, resource, limits etc from parent and also included metrics. This is not good as metrics were updated twice when borrowing resources, one time by child monitor and again by parent monitor which lead to misreporting. This patch removes metrics from inheritance. It is safe to do as metrics could be safely set to nil. It could lead to some memory that is reserved by child pool reported as allocated, but it is better than doing x2. Release note: None Fixes #76898 Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Oleg Afanasyev <[email protected]>
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Feb 28, 2022
Previously we didn't guard against out of bounds column ids in gists,
if a gist is created on a table and then that table drops columns we
would hit a runtime index out of bounds panic. By design gist decoding
is best effort and should silently ignore these columns when this
happens. The columns are used for equality conditions, ie:
└── • lookup join
│ table: broker@broker_pkey
│ equality: (tr_s_symb) = (b_id)
So they are a nice to have. Doing anything more sophisticated would
dramatically increase the gist size so isn't worth it.
Fixes: cockroachdb#76800
Release note: None
RajivTS
pushed a commit
to RajivTS/cockroach
that referenced
this issue
Mar 6, 2022
Previously we didn't guard against out of bounds column ids in gists,
if a gist is created on a table and then that table drops columns we
would hit a runtime index out of bounds panic. By design gist decoding
is best effort and should silently ignore these columns when this
happens. The columns are used for equality conditions, ie:
└── • lookup join
│ table: broker@broker_pkey
│ equality: (tr_s_symb) = (b_id)
So they are a nice to have. Doing anything more sophisticated would
dramatically increase the gist size so isn't worth it.
Fixes: cockroachdb#76800
Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: