-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sql: fix cached gists panic'ing after schema changes
Previously we didn't guard against out of bounds column ids in gists, if a gist is created on a table and then that table drops columns we would hit a runtime index out of bounds panic. By design gist decoding is best effort and should silently ignore these columns when this happens. The columns are used for equality conditions, ie: └── • lookup join │ table: broker@broker_pkey │ equality: (tr_s_symb) = (b_id) So they are a nice to have. Doing anything more sophisticated would dramatically increase the gist size so isn't worth it. Fixes: #76800 Release note: None
- Loading branch information
Showing
3 changed files
with
32 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters