Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: complaints RE: --remote_cache= message #76170

Closed
rickystewart opened this issue Feb 7, 2022 · 0 comments · Fixed by #76201
Closed

dev: complaints RE: --remote_cache= message #76170

rickystewart opened this issue Feb 7, 2022 · 0 comments · Fixed by #76201
Assignees
@rickystewart
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

Currently doctor gives you the following message:

Did you remember to add the --remote_cache=... line to your ~/.bazelrc?

"the --remote_cache= line" in this case is only printed when the cache starts up. That means that you can get the line again w/ dev cache --restart, but that's not clear. Ideally there should be ONE error message here that clearly explains what needs to be changed that is printed whenever you actually need it.

Internal discussion

Epic CRDB-8036
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Feb 7, 2022
@irfansharif irfansharif self-assigned this Feb 7, 2022
@rickystewart rickystewart mentioned this issue Feb 7, 2022
Merged
craig bot pushed a commit that referenced this issue Feb 7, 2022
@RichardJCai @mgartner
@yuzefovich @rickystewart
Merge #75827 #75906 #76176 #76198 #76201
9b46a59 
75827: sql: fix connExecutor extraTxnState autoRetryCounter race condition r=rafiss a=RichardJCai

Release note: None

Fixes #75752

75906: sql: remove type width enforcement during execution r=mgartner a=mgartner

Assignment casts are now responsible for ensuring that a value written
to a column has a type and width that match the column type. This commit
removes the logic that performed this validation before assignment casts
existed.

Release note: None

76176: colexec: change Close to take in a context r=yuzefovich a=yuzefovich

Previously, all `Closer`s would use their own context (either captured
in `Init` or derived from the one in `Init`) in the implementation of
`Close` (for example, when they wanted to log something). However, due
to the way the draining of the wrapped row-by-row processors and
closing of `Closer`s is structured (the draining happens first), it was
possible for the captured context to have a tracing span which was
already `Finish`ed. This is so because the row-by-row processors derive
separate tracing spans and finish them automatically during draining
whereas the closure of `Closer`s happens later.

This commit fixes this issue by passing a context as an argument to
`Close` function, and most of the implementations now use that. Only
components that derive their own tracing span are allowed to use their
own context since they control when the span is finished.

Fixes: #76096.

Release note: None

76198: sql: fix nil pointer error in RunPostDeserializationChanges r=RichardJCai a=RichardJCai

In some restore paths, the privilegeDescriptor would be nil in
RunPostDeserializationChanges, avoid doing work on a nil pointer.

Release note: None

Fixes #76063
Fixes #76062
Fixes #76042

76201: dev: fix up logic computing line which should be added to `~/.bazelrc` r=rail a=rickystewart

Have `setUpCache()` return the specific line it wants to see in
`~/.bazelrc`, and have `doctor` check for the presence of that specific
line. Also explicitly specify `http://` and `127.0.0.1` instead of
`localhost`.

Closes #76170.

Release note: None

Co-authored-by: richardjcai <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in 5211799 Feb 8, 2022
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@rickystewart @RajivTS
dev: fix up logic computing line which should be added to ~/.bazelrc
b2df9fd 
Have `setUpCache()` return the specific line it wants to see in
`~/.bazelrc`, and have `doctor` check for the presence of that specific
line. Also explicitly specify `http://` and `127.0.0.1` instead of
`localhost`.

Closes cockroachdb#76170.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickystewart rickystewart

Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: fix up logic computing line which should be added to ~/.bazelrc rickystewart/cockroach
2 participants
@rickystewart @irfansharif