sql: remove type width enforcement during execution #75906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Feb 2, 2022
| @@ -148,18 +148,9 @@ func GenerateInsertRow( | |||
|
|
|||
| // Verify the column constraints. | |||
| // | |||
| // We would really like to use enforceLocalColumnConstraints() here, | |||
| // but this is not possible because of some brain damage in the | |||
RaduBerinde
approved these changes
Feb 3, 2022
complete! 1 of 0 LGTMs obtained
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
mgartner
force-pushed
the
clean-up-enforce-constraints
branch
from
02c4db9 to
f00eaed
Compare
|
Canceled. |
otan
approved these changes
Feb 4, 2022
mgartner
force-pushed
the
clean-up-enforce-constraints
branch
from
f00eaed to
dc6e740
Compare
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
Assignment casts are now responsible for ensuring that a value written to a column has a type and width that match the column type. This commit removes the logic that performed this validation before assignment casts existed. Release note: None
mgartner
force-pushed
the
clean-up-enforce-constraints
branch
from
dc6e740 to
cc24310
Compare
|
Let's try this again. bors r+ |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment casts are now responsible for ensuring that a value written
to a column has a type and width that match the column type. This commit
removes the logic that performed this validation before assignment casts
existed.
Release note: None