Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the order of SQL Activity tabs and prevent users from landing on the Sessions tab by default #74644

Closed
kevin-v-ngo opened this issue Jan 10, 2022 · 0 comments · Fixed by #75490
Closed

Update the order of SQL Activity tabs and prevent users from landing on the Sessions tab by default #74644

kevin-v-ngo opened this issue Jan 10, 2022 · 0 comments · Fixed by #75490
Assignees
@maryliag
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Jan 10, 2022 •
edited
Loading

We received feedback to avoid having the Sessions tab as the default landing view for the SQL Activity page.

We should keep the order to reflect the hierarchy of a database workload and update the SQL Activity tabs to Statements (default landing view) -> Transactions -> Sessions.

Epic: CRDB-11997
@kevin-v-ngo kevin-v-ngo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Jan 10, 2022
@maryliag maryliag self-assigned this Jan 25, 2022
@maryliag maryliag mentioned this issue Jan 25, 2022
Merged
craig bot pushed a commit that referenced this issue Jan 25, 2022
@maryliag
Merge #75097 #75490
0e932c3 
75097: ui: allow stmts page to search across explain plan page r=gtr a=gtr

Closes #71615.
    
Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.

Demo video: shows that the search feature works for statements' plan

https://user-images.githubusercontent.com/35943354/150594026-ba6325b1-90f1-4830-9b88-c021d4781596.mov

75490: ui: switch order of tabs on SQL Activity r=maryliag a=maryliag

Previously, the tabs under SQL Activity where
Sessions, Transactions and Statements. This commit changes
the order to be Statements, Transactions and Sessions.

Fixes #74644

Release note (ui change): Change the order of tabs under SQL
Activity page to be Statements, Transactions and Sessions.

Co-authored-by: Gerardo Torres <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in b4908da Jan 25, 2022
@blathers-crl blathers-crl bot mentioned this issue Jan 25, 2022
Merged
blathers-crl bot pushed a commit that referenced this issue Jan 25, 2022
@maryliag
ui: switch order of tabs on SQL Activity
78aa1b8 
Previously, the tabs under SQL Activity where
Sessions, Transactions and Statements. This commit changes
the order to be Statements, Transactions and Sessions.

Fixes #74644

Release note (ui change): Change the order of tabs under SQL
Activity page to be Statements, Transactions and Sessions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: switch order of tabs on SQL Activity maryliag/cockroach
2 participants
@maryliag @kevin-v-ngo