Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: allow stmts page search across logical plan text #71615

Closed
dbist opened this issue Oct 15, 2021 · 2 comments · Fixed by #75097
Closed

ui: allow stmts page search across logical plan text #71615

dbist opened this issue Oct 15, 2021 · 2 comments · Fixed by #75097
Assignees
@gtr
Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@dbist
Copy link
Contributor

dbist commented Oct 15, 2021

Is your feature request related to a problem? Please describe.
I'd like to identify queries using a specific index, today the search is going against stmt text only, and unless stmt uses an index hint, my search query is not possible.

Describe the solution you'd like
index the logical plan text so that search by index name is possible.

Describe alternatives you've considered
no solution today

image
image
@dbist dbist added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. labels Oct 15, 2021
@dbist
Copy link
Contributor Author

dbist commented Oct 15, 2021

CC: @kevin-v-ngo

@gtr gtr self-assigned this Jan 11, 2022
@gtr gtr mentioned this issue Jan 13, 2022
Closed
@gtr
Copy link
Contributor

gtr commented Jan 13, 2022 •
edited
Loading

PR: #74820.

We might not want to implement this change for the txns page as the list of stmts for a txn could potentially grow really large.

@kevin-v-ngo kevin-v-ngo changed the title ui: allow stmts/txns page search across logical plan text ui: allow stmts page search across logical plan text Jan 13, 2022
gtr pushed a commit that referenced this issue Jan 18, 2022
ui: allow stmts page to search across explain plan page
0430420 
Partially addresses #71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 18, 2022
ui: allow stmts page to search across explain plan page
e62728e 
Closes: cockroachdb#71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
@gtr gtr mentioned this issue Jan 18, 2022
Merged
gtr pushed a commit that referenced this issue Jan 18, 2022
ui: allow stmts page to search across explain plan page
ced35a7 
Closes #71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 18, 2022
ui: allow stmts page to search across explain plan page
fba0e2e 
Closes cockroachdb#71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 20, 2022
ui: allow stmts page to search across explain plan page
d909c22 
Closes cockroachdb#71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 21, 2022
ui: allow stmts page to search across explain plan page
ac33022 
Closes cockroachdb#71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
gtr pushed a commit to gtr/cockroach that referenced this issue Jan 24, 2022
ui: allow stmts page to search across explain plan page
a1a5a91 
Closes cockroachdb#71615.

Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.
craig bot pushed a commit that referenced this issue Jan 25, 2022
@maryliag
Merge #75097 #75490
0e932c3 
75097: ui: allow stmts page to search across explain plan page r=gtr a=gtr

Closes #71615.
    
Previously, the search functionality for the stmts page only allowed a search
through the statement query. This change adds the statement's Plan as part of
that search.

Release note (ui change): logical plan text included in searchable text for
stmts page.

Demo video: shows that the search feature works for statements' plan

https://user-images.githubusercontent.com/35943354/150594026-ba6325b1-90f1-4830-9b88-c021d4781596.mov

75490: ui: switch order of tabs on SQL Activity r=maryliag a=maryliag

Previously, the tabs under SQL Activity where
Sessions, Transactions and Statements. This commit changes
the order to be Statements, Transactions and Sessions.

Fixes #74644

Release note (ui change): Change the order of tabs under SQL
Activity page to be Statements, Transactions and Sessions.

Co-authored-by: Gerardo Torres <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in 78443e6 Jan 25, 2022
@kevin-v-ngo kevin-v-ngo mentioned this issue Jan 26, 2022
Closed
@kevin-v-ngo kevin-v-ngo mentioned this issue Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtr gtr

Labels
A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: allow stmts page to search across explain plan page gtr/cockroach
2 participants
@dbist @gtr