ui: app filter is not preserved when swtiching between transaction and statement page #71851
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
Azhng
added
C-bug
|
List of locations to update the behaviour:
|
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 18, 2021
Previously, a sort selection was not maintained when the page change (e.g. coming back from Statement details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 22, 2021
72266: colfetcher: populate tableoids on the whole batch at once r=yuzefovich a=yuzefovich Previously, we were populating `tableoid` system column (if requested) when finalizing each row. However, the OID value is constant, so we can populate it when finalizing a batch. `finalizeBatch` becomes no longer inlinable, but we're trading a "per row conditional and Set operation" for a "per batch additional function call", and I think it's probably worth it. Release note: None 72946: ui: save filters on cache for Statements page r=maryliag a=maryliag Previously, a sort selection was not maintained when the page change (e.g. coming back from Statement details). This commits saves the selected value to be used. Partially adresses #71851 Showing behaviour: https://www.loom.com/share/681ca9d80f7145faa111b6aacab417f9 Release note: None 72987: kvserver: increase `Migrate` application timeout to 1 minute r=tbg,ajwerner,miretskiy a=erikgrinaker **kvserver: increase Migrate application timeout to 1 minute** This increases the timeout when waiting for application of a `Migrate` command on all range replicas to 1 minute, up from 5 seconds. It also adds a cluster setting `kv.migration.migrate_application.timeout` to control this. When encountering a range that's e.g. undergoing rebalancing, it can take a long time for a learner replica to receive a snapshot and respond to this request, which would cause the timeout to trigger. This is especially likely in clusters with many ranges and frequent rebalancing activity. Touches #72931. Release note (bug fix): The timeout when checking for Raft application of upgrade migrations has been increased from 5 seconds to 1 minute, and is now controllable via the cluster setting `kv.migration.migrate_application_timeout`. This makes migrations much less likely to fail in clusters with ongoing rebalancing activity during upgrade migrations. **migration: add informative log message for sep intents migrate failure** The separated intents migration has been seen to go into failure loops in the wild, with a generic "context deadline exceeded" error. This adds a more informative log entry with additional hints on how to resolve the problem. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Erik Grinaker <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 23, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 23, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 23, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a sort selection was not maintained when the page change (e.g. coming back from Statement details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 24, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
This was referenced Nov 24, 2021
craig bot
pushed a commit
that referenced
this issue
Nov 24, 2021
71246: sql: remove InternalExecutor from EvalCtx r=rafiss a=RichardJCai Minor refactor to remove duplicate InternalExecutor definition on EvalCtx and in the tree package. We already have 2 interface declarations for InternalExecutor in sql and sqlutil, this refactor hopefully makes the dependencies a little more clear. Resolves #60507 72627: ui: unify cluster-ui stores for Statement and Transaction Page r=maryliag a=Azhng Previously, on CC Conosle, Statement Page and Transaction Page were backed by their own Redux stores and their own Redux Sagas. However, both Statement and Transaction Page were backed by a single API endpoint, namely `/_status/statements`. This resulted in unnecessary API calls and bugs like #72009, which was caused by Reset SQL Stats sagas failing to reset the Transaction Page Redux store. This commit unifies the following Redux store and sagas into a single store / sagas: 1. Statement Page store / sagas 2. Transaciton Page store / sagas 3. Reset SQL Stats store / sagas This greatly removed the code duplication and test duplication and simplify the logic. Statement Page and Transaction Page can reuse the same store by their own selectors. Resolves #72009 Release note: None CC Console: https://user-images.githubusercontent.com/9267198/141212289-00c5196b-87c0-4bae-a163-3542e1a2b6a0.mov DB Console: https://user-images.githubusercontent.com/9267198/141048060-482d23e6-dc77-4868-98dd-e209d0965cf9.mov 73003: ui: save filters on cache for Transactions page r=maryliag a=maryliag Previously, a sort selection was not maintained when the page change (e.g. changing tabs/pages). This commits saves the selected value to be used. Partially adresses #71851 Release note: None 73090: tabledesc: forbid computed columns from having DEFAULT expressions r=postamar a=postamar Previously, we didn't have a table descriptor validation check to ensure that computed columns didn't also have DEFAULT expressions. It is therefore possible that clusters and cluster backups exist in production which contain tables with such columns. This commit therefore fixes this bug by adding the missing validation check, and by removing default expressions from computed columns when necessary after deserializing a descriptor protobuf. Fixes #72881. Release note (sql change, bug fix): fixes a bug which allowed computed columns to also have DEFAULT expressions. 73125: opt: prevent creation of invalid streaming set operations r=rytaft a=rytaft Prior to this commit, it was possible to generate a streaming set operation with an empty ordering, due to using interesting orderings involving input columns that were not output by the set operation. This commit fixes the problem by removing those orderings from consideration. Fixes #73084 Release note (bug fix): Fixed an internal error that could occur during planning for some set operations (e.g., UNION, INTERSECT or EXCEPT) when at least one side of the set operation was ordered on a column that was not output by the set operation. This bug was first introduced in 21.2.0 and does not exist in prior versions. 73132: bazel: upgrade to `rules_nodejs` 4.4.6, `nodejs` 16.13.0 r=rail a=rickystewart This comes w/ support for Applie Silicon Macs. Closes #72829. Release note: None 73136: dev: add `go` command to `dev` r=rail a=rickystewart Just allows you to run `go` without actually having it installed. Maybe no one will use this but me, I don't know :) Release Note: None 73140: CODEOWNERS: move rttanalysis to sql-schema r=postamar a=rafiss I believe this is more accurate. Release note: None Co-authored-by: richardjcai <[email protected]> Co-authored-by: Azhng <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Rebecca Taft <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 25, 2021
73134: ui: save search query on cache for Statements page r=maryliag a=maryliag Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses #71851 Release note: None Co-authored-by: Marylia Gutierrez <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Nov 25, 2021
Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses cockroachdb#71851 Release note: None
craig bot
pushed a commit
that referenced
this issue
Nov 25, 2021
72660: roachpb/server: add new endpoint for getting a table's index stats r=lindseyjin a=lindseyjin Partially addresses #67647 Previously, we had an RPC endpoint for retrieving all index usage statistics. However, this endpoint should only be used for internal purposes. We needed an endpoint that can be exposed to the frontend, for use in the Index Stats table (which will be created in a following commit). Hence, this commit creates a new RPC endpoint and functions that read the required index usage statistics directly from the database using SQL. Instead of returning all index usage statistics, we only retrieve the indexes for a specified database and table. Release note (api change): Add new api endpoint for getting a table's index statistics. 73135: ui: save search query on cache for Transactions page r=maryliag a=maryliag Previously, a search was not maintained when the page change (e.g. coming back from Transaction details). This commits saves the selected value to be used. Partially adresses #71851 Release note: None 73139: backupccl: fix bug in database and schema restore cleanup r=stevendanna,RichardJCai a=adityamaru This change fixes a bug where during restore cleanup we would delete the database descriptor, and namespace entry only to add the descriptor entry back when clearing the schema references in the database desc slice. We fix this by first clearing the schema reference in the db descroptor slice, and then going through the motions of dropping the database descriptor. Fixes: #72248 Release note (bug fix): Fix bug in database and schema restore cleanup that results in a dangling descriptor entry on job failure. Co-authored-by: Lindsey Jin <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: Aditya Maru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction steps
Screen.Recording.2021-10-21.at.18.22.43.mov
The text was updated successfully, but these errors were encountered: