Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: upgrade to rules_nodejs 4.4.6, nodejs 16.13.0 #73132

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

rickystewart
Copy link
Collaborator

This comes w/ support for Applie Silicon Macs. Closes #72829.

Release note: None

This comes w/ support for Applie Silicon Macs. Closes cockroachdb#72829.

Release note: None
@rickystewart rickystewart requested a review from rail November 24, 2021 19:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp.

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Nov 24, 2021

Build succeeded:

@craig craig bot merged commit 8fa3a38 into cockroachdb:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: cannot build full cockroach binary on M1 Macs due to missing NodeJS repo
3 participants