workload: tolerate special chars in histogram names #66491
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
tbg
added
the
C-bug
tbg
added a commit
to tbg/cockroach
that referenced
this issue
Jun 15, 2021
When we added prometheus histograms we did not realize that this method would register a histogram containing special characters. This would break the roachtest run; it hasn't been running for a few days. This is a hotfix to get it back on its feet. Real fix is tracked in: cockroachdb#66491 cc @cockroachdb/test-eng @cockroachdb/bulk-io Release note: None
|
As part of fixing this, we also need to undo #66492 (comment). |
craig bot
pushed a commit
that referenced
this issue
Jun 15, 2021
66492: roachtest: skip initBulkJobPerfArtifacts r=adityamaru a=tbg When we added prometheus histograms we did not realize that this method would register a histogram containing special characters. This would break the roachtest run; it hasn't been running for a few days. This is a hotfix to get it back on its feet. Real fix is tracked in: #66491 cc @cockroachdb/test-eng @cockroachdb/bulk-io Release note: None Co-authored-by: Tobias Grieger <[email protected]>
|
We fixed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
The histograms package will panic if a histogram contains characters that prometheus disallows in metrics names.
To Reproduce
https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1623776034188400
Expected behavior
We need to either gracefully reject such metric names or eliminiate the special chars under the hood.
Additional data / screenshots
Environment:
Additional context
Lost 5 days of roachtest
The text was updated successfully, but these errors were encountered: