Merge #66492

66492: roachtest: skip initBulkJobPerfArtifacts r=adityamaru a=tbg When we added prometheus histograms we did not realize that this method would register a histogram containing special characters. This would break the roachtest run; it hasn't been running for a few days. This is a hotfix to get it back on its feet. Real fix is tracked in: #66491 cc @cockroachdb/test-eng @cockroachdb/bulk-io Release note: None Co-authored-by: Tobias Grieger <[email protected]>
cockroachdb · Jun 15, 2021 · 63ac8bd · 63ac8bd
2 parents 734919d + 058148c
commit 63ac8bd
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/cmd/roachtest/backup.go b/pkg/cmd/roachtest/backup.go
@@ -144,6 +144,10 @@ func registerBackupNodeShutdown(r *testRegistry) {
 // initBulkJobPerfArtifacts registers a histogram, creates a performance
 // artifact directory and returns a method that when invoked records a tick.
 func initBulkJobPerfArtifacts(ctx context.Context, testName string, timeout time.Duration) func() {
+	// TODO(tbg,aditya): this is temporarily skipped, figure out a fix. See:
+	// https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1623776034188400
+	return func() {}
+
 	// Register a named histogram to track the total time the bulk job took.
 	// Roachperf uses this information to display information about this
 	// roachtest.