Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/importccl: TestProtectedTimestampsDuringImportInto failed #62864

Closed
cockroach-teamcity opened this issue Mar 31, 2021 · 0 comments · Fixed by #62870
Closed

ccl/importccl: TestProtectedTimestampsDuringImportInto failed #62864

cockroach-teamcity opened this issue Mar 31, 2021 · 0 comments · Fixed by #62870
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(ccl/importccl).TestProtectedTimestampsDuringImportInto failed on master@c6125c3c5f4e416382c19adfaebe6c2190977190:

=== RUN   TestProtectedTimestampsDuringImportInto
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestProtectedTimestampsDuringImportInto005524695
    test_log_scope.go:74: use -show-logs to present logs inline
n1: found liveness
E210331 12:12:05.331931 550735 storage/cloudimpl/http_storage.go:195  [n1,job=645930425636913153,import-distsql-ingest] 1  HTTP:Req error: err=error response from server: 500 Internal Server Error "" (attempt 0)
E210331 12:12:05.365749 550586 jobs/adopt.go:260  [n1] 2  job 645930425636913153: adoption completed with error error response from server: 500 Internal Server Error ""
    sql_runner.go:224: error executing 'SELECT * FROM foo': pq: relation "foo" is offline: importing
E210331 12:12:05.377353 549479 jobs/registry.go:696  [-] 3  error claiming jobs: could not query jobs table: claim-jobs: context canceled
E210331 12:12:05.379465 549479 jobs/registry.go:706  [-] 4  error processing claimed jobs: could not query for claimed jobs: select-running/get-claimed-jobs: context canceled
    panic.go:617: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestProtectedTimestampsDuringImportInto005524695
--- FAIL: TestProtectedTimestampsDuringImportInto (3.52s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestProtectedTimestampsDuringImportInto PKG=./pkg/ccl/importccl TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 31, 2021
craig bot pushed a commit that referenced this issue Mar 31, 2021
60947: bulkio: make backup, restore, and import more resilient to node failures r=pbardea a=pbardea

This PR extracts error helpers that were specific to the changefeedccl package, so that they can
be used by all other jobs that run long-running DistSQL flows. This allows all jobs to be resilient to
node failures.

This commit does not fix that less-than-ideal error handling used to detect RPC failures from
DistSQL flow, but does aim to centralize the checks so that they occur only in 1 place.

Informs #50732.

Please see individual commits.

Release-justification: high impact fix

62452: ui: Replace "Admin UI" with "DB Console" on login r=nathanstilwell a=nathanstilwell

Changed a few remaining instances of "Admin UI" to "DB Console" that
were spotted on the login page.

Release note (ui change): Change copy that referred to the app as "Admin
UI" to "DB Console" instead

62870: Revert "sql: lease acquisition of OFFLINE descs may starve bulk operations" r=ajwerner a=fqazi

Fixes: #62864, #62853, #62849, #62844

Reverts offline descriptor leasing change to fix
intermittent failures introduced inside the
importccl tests.

Release note: None

Co-authored-by: Paul Bardea <[email protected]>
Co-authored-by: Nathan Stilwell <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
@craig craig bot closed this as completed in 3e1c9f1 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants