Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/importccl: TestImportIntoCSV failed #62853

Closed
cockroach-teamcity opened this issue Mar 31, 2021 · 1 comment · Fixed by #63088
Closed

ccl/importccl: TestImportIntoCSV failed #62853

cockroach-teamcity opened this issue Mar 31, 2021 · 1 comment · Fixed by #63088
Assignees
@pbardea
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test

Comments

@cockroach-teamcity
Copy link
Member

(ccl/importccl).TestImportIntoCSV failed on master@fe14895b103aae7f969ebf90763802629ad209c5:

=== RUN   TestImportIntoCSV
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestImportIntoCSV845252864
    test_log_scope.go:74: use -show-logs to present logs inline
=== CONT  TestImportIntoCSV
    import_stmt_test.go:3433: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestImportIntoCSV845252864
--- FAIL: TestImportIntoCSV (78.12s)
=== RUN   TestImportIntoCSV/empty-file
    import_stmt_test.go:2879: error scanning '&{0xc00207c120 <nil>}': pq: relation "t" is offline: importing
    --- FAIL: TestImportIntoCSV/empty-file (1.46s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestImportIntoCSV PKG=./pkg/ccl/importccl TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 31, 2021
@tbg tbg removed their assignment Mar 31, 2021
tbg added a commit to tbg/cockroach that referenced this issue Mar 31, 2021
@tbg
ccl/importccl: skip TestImportIntoCSV
42dff22 
Refs: cockroachdb#62853

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@tbg tbg mentioned this issue Mar 31, 2021
Merged
@pbardea pbardea self-assigned this Mar 31, 2021
craig bot pushed a commit that referenced this issue Mar 31, 2021
@tbg
Merge #62865
99c29ef 
62865: ccl/importccl: skip TestImportIntoCSV r=pbardea a=tbg

Refs: #62853

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Tobias Grieger <[email protected]>
@cockroach-teamcity
Copy link
Member Author

(ccl/importccl).TestImportIntoCSV failed on master@c6125c3c5f4e416382c19adfaebe6c2190977190:

=== RUN   TestImportIntoCSV
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestImportIntoCSV267930830
    test_log_scope.go:74: use -show-logs to present logs inline
=== CONT  TestImportIntoCSV
    import_stmt_test.go:3433: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestImportIntoCSV267930830
--- FAIL: TestImportIntoCSV (68.54s)
=== RUN   TestImportIntoCSV/empty-with-files
    import_stmt_test.go:2891: error scanning '&{0xc00ecd9c20 <nil>}': pq: relation "t" is offline: importing
    --- FAIL: TestImportIntoCSV/empty-with-files (0.70s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestImportIntoCSV PKG=./pkg/ccl/importccl TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@spaskob spaskob mentioned this issue Mar 31, 2021
Closed
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 31, 2021
@fqazi
Revert "sql: lease acquisition of OFFLINE descs may starve bulk opera…
3e1c9f1 
…tions"

Fixes: cockroachdb#62864, cockroachdb#62853, cockroachdb#62849, cockroachdb#62844

Reverts offline descriptor leasing change to fix
intermittent failures introduced inside the
importccl tests.

Release note: None
@fqazi fqazi mentioned this issue Mar 31, 2021
Merged
craig bot pushed a commit that referenced this issue Mar 31, 2021
@pbardea @fqazi
Merge #60947 #62452 #62870
46a8edd 
60947: bulkio: make backup, restore, and import more resilient to node failures r=pbardea a=pbardea

This PR extracts error helpers that were specific to the changefeedccl package, so that they can
be used by all other jobs that run long-running DistSQL flows. This allows all jobs to be resilient to
node failures.

This commit does not fix that less-than-ideal error handling used to detect RPC failures from
DistSQL flow, but does aim to centralize the checks so that they occur only in 1 place.

Informs #50732.

Please see individual commits.

Release-justification: high impact fix

62452: ui: Replace "Admin UI" with "DB Console" on login r=nathanstilwell a=nathanstilwell

Changed a few remaining instances of "Admin UI" to "DB Console" that
were spotted on the login page.

Release note (ui change): Change copy that referred to the app as "Admin
UI" to "DB Console" instead

62870: Revert "sql: lease acquisition of OFFLINE descs may starve bulk operations" r=ajwerner a=fqazi

Fixes: #62864, #62853, #62849, #62844

Reverts offline descriptor leasing change to fix
intermittent failures introduced inside the
importccl tests.

Release note: None

Co-authored-by: Paul Bardea <[email protected]>
Co-authored-by: Nathan Stilwell <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
spaskob pushed a commit to spaskob/cockroach that referenced this issue Mar 31, 2021
importccl: skip flaky test
0c619f1 
cockroachdb#62853

Release note: none.
@cockroach-teamcity cockroach-teamcity mentioned this issue Apr 1, 2021
Closed
@pbardea pbardea mentioned this issue Apr 5, 2021
Merged
@craig craig bot closed this as completed in e7f7244 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbardea pbardea

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importccl: unskip TestImportIntoCSV pbardea/cockroach
3 participants
@pbardea @tbg @cockroach-teamcity