Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: figure out support for crdb_test, crdb_test_off tags within Bazel build #61724

Closed
rickystewart opened this issue Mar 9, 2021 · 1 comment · Fixed by #62468
Closed

bazel: figure out support for crdb_test, crdb_test_off tags within Bazel build #61724

rickystewart opened this issue Mar 9, 2021 · 1 comment · Fixed by #62468
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@rickystewart
Copy link
Collaborator

A brute-force solution is to manually identify all the tests that are broken if these tags are not appropriately set, and set the gotags.
@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system labels Mar 9, 2021
@yuzefovich
Copy link
Member

I think we would like to have the same behavior as we currently have with make - that all test targets have crdb_test build tag set by default - since presence of the flag enables additional verifications and assertions. If with bazel tests we simply not add a tag and see what's broken, I'm pretty sure that nothing will be broken (#61317 is an exception).

@rickystewart rickystewart mentioned this issue Mar 23, 2021
Merged
craig bot pushed a commit that referenced this issue Mar 23, 2021
@yuzefovich @stevendanna
@kannanlakshmi @rickystewart
Merge #62402 #62443 #62448 #62468
35a64c6 
62402: roachtest: not fail sqlsmith on known issue r=yuzefovich a=yuzefovich

This commit makes `sqlsmith` roachtest not fail on one known issue (#40929)
in order to avoid unnecessary noise.

Release note: None

62443: lint: don't use -unused.whole-program when PKG is specified r=HonoreDB a=stevendanna

The unused linter's whole program mode will create false-positives
when PKG is specified. As a result, anyone trying to use

    make lint PKG=./pkg/SOMETHING

has to carefully read the failure output to see if it was actually a
success. By not passing that flag when PKG is specified, more cases of
the above command complete without erroneous findings.

Release note: None

62448: Update README.md r=j-low a=kannanlakshmi

Updated quick start section to include a link to CockroachCloud

62468: bazel: set `crdb_test`, `crdb_test_off` build tags appropriately r=rickystewart a=rickystewart

Fixes #61724

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: Lakshmi Kannan <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in f69bc7f Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: set crdb_test, crdb_test_off build tags appropriately rickystewart/cockroach
2 participants
@rickystewart @yuzefovich