roachtest: not fail sqlsmith on known issue

[yuzefovich]

This commit makes sqlsmith roachtest not fail on one known issue (#40929)
in order to avoid unnecessary noise.

Release note: None

[cockroach-teamcity]

This change is 

[RaduBerinde]

[nit] The PR and commit description says "skips filing roachtest" which is fortunately not what we're doing.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @asubiotto, @jordanlewis, and @yuzefovich)

---

pkg/cmd/roachtest/sqlsmith.go, line 216 at r1 (raw file):

				// TODO(yuzefovich): we temporarily ignore internal errors that
				// are because of #39433 and #40929.
				var expectedInternalErrors = []string{

[nit] move this inside the if.

---

pkg/cmd/roachtest/sqlsmith.go, line 218 at r1 (raw file):

				var expectedInternalErrors = []string{
					"internal error: invalid index",
					"could not parse \"0E-2019\" as type decimal",

Interesting that it errors out only with this particular value!

[yuzefovich]

Updated the commit message. I was trying to use "failing" not as adjective but as a gerund, but I agree that it is very confusing :)

TFTR!

bors r+

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @asubiotto and @jordanlewis)

---

pkg/cmd/roachtest/sqlsmith.go, line 216 at r1 (raw file):

Previously, RaduBerinde wrote…

[nit] move this inside the if.

Done.

[craig]

Build failed (retrying...):

• GitHub CI (Cockroach)

[craig]

Build succeeded:

• GitHub CI (Cockroach)