Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvnemesis: TestKVNemesisMultiNode failed #58624

Closed
cockroach-teamcity opened this issue Jan 7, 2021 · 1 comment · Fixed by #58919
Closed

kv/kvnemesis: TestKVNemesisMultiNode failed #58624

cockroach-teamcity opened this issue Jan 7, 2021 · 1 comment · Fixed by #58919
Assignees
@aayushshah15
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(kv/kvnemesis).TestKVNemesisMultiNode failed on master@d8b5cb0fdd5f0b1b28919539b78c17aee68dc5f4:

          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replica_command.go:763
          |   | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).executeAdminBatch
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replica_send.go:575
          |   | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).sendWithRangeID
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replica_send.go:100
          |   | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Replica).Send
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/replica_send.go:36
          |   | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).Send
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/store_send.go:195
          |   | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Stores).Send
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvserver/stores.go:177
          |   | github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:874
          |   | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunTaskWithErr
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:326
          |   | github.com/cockroachdb/cockroach/pkg/server.(*Node).batchInternal
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:862
          |   | github.com/cockroachdb/cockroach/pkg/server.(*Node).Batch
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/server/node.go:900
          |   | github.com/cockroachdb/cockroach/pkg/roachpb._Internal_Batch_Handler.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/roachpb/api.pb.go:9083
          |   | github.com/cockroachdb/cockroach/pkg/util/tracing.ServerInterceptor.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/util/tracing/grpc_interceptor.go:136
          |   | google.golang.org/grpc.getChainUnaryHandler.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:921
          |   | github.com/cockroachdb/cockroach/pkg/rpc.NewServer.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/rpc/context.go:176
          |   | google.golang.org/grpc.getChainUnaryHandler.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:921
          |   | github.com/cockroachdb/cockroach/pkg/rpc.kvAuth.unaryInterceptor
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/rpc/auth.go:60
          |   | google.golang.org/grpc.chainUnaryServerInterceptors.func1
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:907
          |   | github.com/cockroachdb/cockroach/pkg/roachpb._Internal_Batch_Handler
          |   | 	/go/src/github.com/cockroachdb/cockroach/pkg/roachpb/api.pb.go:9085
          |   | google.golang.org/grpc.(*Server).processUnaryRPC
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:1082
          |   | google.golang.org/grpc.(*Server).handleStream
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:1405
          |   | google.golang.org/grpc.(*Server).serveStreams.func1.1
          |   | 	/go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:746
          |   | runtime.goexit
          |   | 	/usr/local/go/src/runtime/asm_amd64.s:1374
          | Wraps: (2) cannot merge ranges when lhs is in a joint state or has learners: (n1,s1):1,(n3,s3):2LEARNER
          | Error types: (1) *errbase.opaqueWrapper (2) *errutil.leafError
        Wraps: (7) merge failed: cannot merge ranges when lhs is in a joint state or has learners: (n1,s1):1,(n3,s3):2LEARNER
        Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *errbase.opaqueWrapper (4) *errutil.withPrefix (5) *errbase.opaqueWrapper (6) *secondary.withSecondaryError (7) *errutil.leafError
    kvnemesis_test.go:84: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestKVNemesisMultiNode253320323
--- FAIL: TestKVNemesisMultiNode (1.42s)
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestKVNemesisMultiNode PKG=./pkg/kv/kvnemesis TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jan 7, 2021
@postamar postamar mentioned this issue Jan 12, 2021
Merged
otan added a commit to otan-cockroach/cockroach that referenced this issue Jan 13, 2021
@otan
kv/kvnemesis: skip TestKVNemesisMultiNode
12428a0 
Refs: cockroachdb#58624

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@otan otan mentioned this issue Jan 13, 2021
Merged
craig bot pushed a commit that referenced this issue Jan 13, 2021
@otan
Merge #58898 #58907
70d2bfe 
58898: tabledesc: omit implicit columns from auto-generated index names r=ajstorm a=otan

Release note (sql change): Omit the inclusion of implicit columns or
hash sharded index columns from automatically generated index names.

58907: kv/kvnemesis: skip TestKVNemesisMultiNode r=rafiss a=otan

Refs: #58624

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Oliver Tan <[email protected]>
@aayushshah15 aayushshah15 assigned aayushshah15 and unassigned tbg Jan 13, 2021
@aayushshah15
Copy link
Contributor

This is due to #56197. I had changed the error string. I'll take it.

@aayushshah15 aayushshah15 mentioned this issue Jan 13, 2021
Merged
nvanbenschoten pushed a commit to nvanbenschoten/cockroach that referenced this issue Jan 14, 2021
@aayushshah15 @nvanbenschoten
kvnemesis: fix and unskip TestKVNemesisMultiNode
9e28ee4 
Before this patch, cockroachdb#56197 broke this test because it changed a range
merge error string that let the KV nemesis validator ignore the error.
This patch updates the regexp the validator uses to match the error and
unskips the test.

Fixes cockroachdb#58624.

Release note: None
craig bot pushed a commit that referenced this issue Jan 14, 2021
@aayushshah15 @otan
Merge #58888 #58919 #58982
481cb43 
58888: sql, jobs: stop queuing schema change jobs for in-txn schema changes r=postamar a=postamar

Creating a table and changing its schema within a transaction would
cause a schema change job to be queued. Such jobs are not necessary and
don't do anything. This patch prevents them from being queued in the
first place.

Fixes #45985.

Release note (sql change): Creating a table and changing its schema
within a transaction no longer schedules a schema change job.

58919: kvnemesis: fix and unskip TestKVNemesisMultiNode r=aayushshah15 a=aayushshah15

Before this patch, #56197 broke this test because it changed a range
merge error string that let the KV nemesis validator ignore the error.
This patch updates the regexp the validator uses to match the error and
unskips the test.

Fixes #58624.

Release note: None

58982: delegate: remove is_active_region from SHOW REGIONS FROM DATABASE r=ajstorm a=otan

Due to unpopular demand.

Release note: None

Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Aayush Shah <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
@craig craig bot closed this as completed in cdc0b55 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aayushshah15 aayushshah15

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvnemesis: fix and unskip TestKVNemesisMultiNode aayushshah15/cockroach
3 participants
@tbg @aayushshah15 @cockroach-teamcity