Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg_catalog diff tool works against information_schema tables #58037

Closed
vy-ton opened this issue Dec 17, 2020 · 1 comment · Fixed by #60283
Closed

pg_catalog diff tool works against information_schema tables #58037

vy-ton opened this issue Dec 17, 2020 · 1 comment · Fixed by #60283
Assignees
@mnovelodou
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@vy-ton
Copy link
Contributor

vy-ton commented Dec 17, 2020

We should be able to run the pg_catalog diff tool and compare CockraochDB's and Postgres information_schema tables for the tables that Postgres supports.
@blathers-crl
Copy link

blathers-crl bot commented Dec 17, 2020

Hi @vy-ton, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Dec 17, 2020
@mnovelodou mnovelodou self-assigned this Feb 9, 2021
mnovelodou pushed a commit to mnovelodou/cockroach that referenced this issue Feb 9, 2021
sql: improved diff tool for any namespace
b27e131 
Previously, diff tool worked only for pg_catalog
This was inadequate because it can be used for information_schema as well
To address this, this patch takes the namespace as parameter to compare a
different database

Release note: None

Fixes cockroachdb#58037
@mnovelodou mnovelodou mentioned this issue Feb 9, 2021
Merged
mnovelodou pushed a commit to mnovelodou/cockroach that referenced this issue Feb 25, 2021
sql: improved diff tool for any namespace
a8dec9f 
Previously, diff tool worked only for pg_catalog
This was inadequate because it can be used for information_schema as well
To address this, this patch takes the namespace as parameter to compare a
different database

Release note: None

Fixes cockroachdb#58037

Release justification: non-production code changes
mnovelodou pushed a commit to mnovelodou/cockroach that referenced this issue Mar 1, 2021
sql: improved diff tool for any namespace
6f89411 
Previously, diff tool worked only for pg_catalog
This was inadequate because it can be used for information_schema as well
To address this, this patch takes the namespace as parameter to compare a
different database

Release note: None

Fixes cockroachdb#58037

Release justification: non-production code changes
craig bot pushed a commit that referenced this issue Mar 3, 2021
@yuzefovich @rafiss
@rytaft @andreimatei
Merge #59339 #60283 #61263 #61304 #61321 #61348 #61375
4ab29d4 
59339: sql: audit all usages of Query to use iterator pattern r=yuzefovich a=yuzefovich

Similarly to the previous commit (dbc8676), here we audit all usages of `Query`
method of the internal executor to take advantage of the iterator API
wherever possible (or switching to `Exec` or `QueryRow`).
`QueryBuffered` has been added to the interface too.

The only place where it would be beneficial to use the iterator pattern
but it is not done currently is for `SHOW STATISTICS` statement - in
there, we have a panic-catcher which works only on the assumption of not
updating any of the shared state (which the iterator API contradicts).
Refactoring that part is left as a TODO.

Fixes: #48595.

Release justification: low-risk update to existing functionality.

Release note: None

60283: sql: improved diff tool for any namespace r=rafiss a=mnovelodou

Previously, diff tool worked only for pg_catalog
This was inadequate because it can be used for information_schema as well
To address this, this patch takes the namespace as parameter to compare a
different database

Release note: None
Release justification: non-production code changes

Fixes #58037

61263: roachtest: mark pgx prepared stmt test as passing r=otan a=rafiss

fixes #61250 

Release justification: testing only change

Release note: None

61304: ccl: test that local scan is planned for RBR table with computed region r=rytaft a=rytaft

This commit adds a test that a local scan is planned for a `REGIONAL BY ROW`
table with a computed region column.

Informs #57722

Release justification: non-production code changes.

Release note: None

61321: sql: fix tracing of postqueries r=yuzefovich a=yuzefovich

When we're performing tracing, we derive a special `consumeCtx` when
creating a DistSQLReceiver for the whole plan. That context should be
used for all components of the physical plan (main query, sub- and
post-queries), and the span needs to be finished by calling the stored
`cleanup` function. Previously, this was called in `ProducerDone` of the
main query which resulted in the span being finished before the
post-queries are run. As a result, the tracing spans for cascades and
checks could be incomplete.

This commit fixes the problem by delaying the finish of the span until
the DistSQLReceiver is released (since it is a convenient place that all
callers of `MakeDistSQLReceiver` call in a deferred invocation).

Release justification: bug fix.

Release note (bug fix): Previously, the traces of cascades and checks
could be incomplete, and now it is fixed.

61348: sql: fixing information_schema.columns.is_identity r=rafiss a=mnovelodou

Previously, information_schema.columns.is_identity was set to null
This was inadequate because is incorrect value
To address this, this patch sets column to NO as identity columns
are not yet supported

Release justification: bug fixes and low-risk updates to new functionality
Release note (sql change): fixed information_schema.columns.is_identity to
display the correct value

Fixes #61011

61375: kvserver: add a log.Scope r=andreimatei a=andreimatei

Release note: None
Release justification: Test only.

Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: MiguelNovelo <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Rebecca Taft <[email protected]>
Co-authored-by: Andrei Matei <[email protected]>
@craig craig bot closed this as completed in f95040f Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnovelodou mnovelodou

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: improved diff tool for any namespace mnovelodou/cockroach
2 participants
@vy-ton @mnovelodou